From:   "Colin King (gmail)" <colin.i.king@googlemail.com>
Message-ID: <74e233c2-fe6a-4f90-4e26-14eb5c72321b@gmail.com>
Date:   Wed, 10 Nov 2021 23:26:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] MIPS: generic/yamon-dt: fix uninitialized variable error
Content-Language: en-US
To:     Colin Ian King <colin.i.king@googlemail.com>,
        Paul Burton <paulburton@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211110232538.1372250-1-colin.i.king@gmail.com>
In-Reply-To: <20211110232538.1372250-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/2021 23:25, Colin Ian King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> In the case where fw_getenv returns an error when fetching values
> for ememsizea and memsize then variable phys_memsize is not assigned
> a variable and will be uninitialized on a zero check of phys_memsize.
> Fix this by initializing phys_memsize to zero.
> 
> Cleans up cppcheck error:
> arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]
> 
> Fixes: f41d2430bbd6 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   arch/mips/generic/yamon-dt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/generic/yamon-dt.c b/arch/mips/generic/yamon-dt.c
> index a3aa22c77cad..a07a5edbcda7 100644
> --- a/arch/mips/generic/yamon-dt.c
> +++ b/arch/mips/generic/yamon-dt.c
> @@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array(
>   __init int yamon_dt_append_memory(void *fdt,
>   				  const struct yamon_mem_region *regions)
>   {
> -	unsigned long phys_memsize, memsize;
> +	unsigned long phys_memsize = 0, memsize;
>   	__be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];
>   	unsigned int mem_entries;
>   	int i, err, mem_off;
> 

Oops, old SoB. I'll resend a V2.