MIME-Version: 1.0
References: <20211110230138.3883950-1-almasrymina@google.com> <CALvZod6o68s150XFoDFPmaHeiGxQGmTzARE7qrr0KHo4Mpi1BQ@mail.gmail.com>
In-Reply-To: <CALvZod6o68s150XFoDFPmaHeiGxQGmTzARE7qrr0KHo4Mpi1BQ@mail.gmail.com>
From:   Mina Almasry <almasrymina@google.com>
Date:   Wed, 10 Nov 2021 16:30:30 -0800
Message-ID: <CAHS8izM9LKZDbVbHeegsV1uTX1_YSPuNFMwLMpQ-28=2ot8V9A@mail.gmail.com>
Subject: Re: [PATCH v5] hugetlb: Add hugetlb.*.numa_stat file
To:     Shakeel Butt <shakeelb@google.com>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Oscar Salvador <osalvador@suse.de>,
        Michal Hocko <mhocko@suse.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Rientjes <rientjes@google.com>,
        Jue Wang <juew@google.com>, Yang Yao <ygyao@google.com>,
        Joanna Li <joannali@google.com>,
        Cannon Matthews <cannonmatthews@google.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 10, 2021 at 4:08 PM Shakeel Butt <shakeelb@google.com> wrote:
>
> On Wed, Nov 10, 2021 at 3:01 PM Mina Almasry <almasrymina@google.com> wrote:
> >
> [...]
> >
> > +struct hugetlb_cgroup_per_node {
> > +       /* hugetlb usage in pages over all hstates. */
> > +       unsigned long usage[HUGE_MAX_HSTATE];
> > +};
> > +
>
> You missed my other question. Why do you think concurrent access to
> this struct is safe?

Oh, very sorry. I'll upload another iteration with a fix!