Date:   Thu, 11 Nov 2021 17:20:56 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Randy Dunlap <rdunlap@infradead.org>
cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Mike Rapoport <rppt@kernel.org>, Sam Creasey <sammy@sammy.net>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Enable memtest kernel parameter
In-Reply-To: <725c0578-d816-f0c9-175a-7400c4a01887@infradead.org>
Message-ID: <fc341bdf-a145-3a6b-5325-eb8dce2f1cf4@linux-m68k.org>
References: <a57524fe38123ea17a6741cdc282f6c84c30a009.1636593047.git.fthain@linux-m68k.org> <725c0578-d816-f0c9-175a-7400c4a01887@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 10 Nov 2021, Randy Dunlap wrote:

> On 11/10/21 5:10 PM, Finn Thain wrote:
> > Enable the memtest feature and rearrange some code to prevent it from
> > clobbering the initrd.
> > 
> > The CONFIG_BLK_DEV_INITRD symbol was conditional on !defined(CONFIG_SUN3).
> > For simplicity, remove that test on the basis that m68k_ramdisk.size == 0
> > on Sun 3.
> > 
> > The SLIME source code athttp://sammy.net/  shows that no BI_RAMDISK entry
> > is ever passed to the kernel due to #ifdef 0 around the relevant code.
> > 
> > Cc: Mike Rapoport<rppt@kernel.org>
> > Cc: Sam Creasey<sammy@sammy.net>
> > Signed-off-by: Finn Thain<fthain@linux-m68k.org>
> > ---
> > Are there any other Linux bootloaders on Sun 3?
> > ---
> >   arch/m68k/Kconfig           |  1 +
> >   arch/m68k/kernel/setup_mm.c | 15 ++++++---------
> >   arch/m68k/mm/motorola.c     |  2 ++
> >   3 files changed, 9 insertions(+), 9 deletions(-)
> 
> Hi Finn,
> 
> Please also update Documentation/admin-guide/kernel-parameters.txt:
> 
> 	memtest=	[KNL,X86,ARM,PPC,RISCV] Enable memtest
> 
> to include "M68K".
> 
> thanks.
> 

Will do.

Thanks for your review.