Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A1A5C433EF for ; Thu, 11 Nov 2021 06:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 697086112F for ; Thu, 11 Nov 2021 06:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbhKKGpK (ORCPT ); Thu, 11 Nov 2021 01:45:10 -0500 Received: from mga02.intel.com ([134.134.136.20]:42558 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhKKGpE (ORCPT ); Thu, 11 Nov 2021 01:45:04 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="220065048" X-IronPort-AV: E=Sophos;i="5.87,225,1631602800"; d="scan'208";a="220065048" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 22:42:15 -0800 X-IronPort-AV: E=Sophos;i="5.87,225,1631602800"; d="scan'208";a="452618122" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 22:42:12 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 11 Nov 2021 08:42:09 +0200 Date: Thu, 11 Nov 2021 08:42:09 +0200 From: Mika Westerberg To: Mauro Lima Cc: Andy Shevchenko , Hans-Gert Dahmen , Greg KH , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , Philipp Deppenwiese , Richard Hughes , "platform-driver-x86@vger.kernel.org" Subject: Re: [PATCH] firmware: export x86_64 platform flash bios region via sysfs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Nov 10, 2021 at 02:37:56PM -0300, Mauro Lima wrote: > > Try again to collaborate with Intel SPI driver author(s) / > > maintainer(s) by sending the proposal that may work. > > The proposal I sent makes the driver work only with read ops, but that > was not the issue with this driver. The issue was something related to > a status register and this was fixed. So if there is no issue with > write/erase ops, the bug was fixed and there is no intention to remove > the tag. What kind of proposal are we talking about? I think we discussed this previously already but in any case, instead of removing the tag from the "main" driver, we can make certain "safe" parts of the driver available without that tag. That would allow you to read the things the controller exposes and allow distros safely include the driver too. By "safe" parts, I mean the information available through the SPI flash controller without actually sending commands to the flash chip. I think this is the information everybody (on this thread at least) is interested in. Unless I'm mistaken - I did not check the original patch. If that's not enough we can possibly expand it to cover the controllers that only use hardware sequencer since they operate on a certain limited set of ops that should not break anything accidentally.