Date:   Thu, 11 Nov 2021 10:39:50 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mark Gross <markgross@kernel.org>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Vadim Pasternak <vadimp@nvidia.com>,
        Michael Shych <michaelsh@nvidia.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/mellanox: mlxreg-lc: fix error code in
 mlxreg_lc_create_static_devices()
Message-ID: <20211111073949.GO2026@kadam>
References: <20211110074346.GB5176@kili>
 <20211110223147.GA16388@T470>
 <20211111073341.GN2001@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211111073341.GN2001@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3sOGNKYCfyvYwSpHLz+t5j6HXoAkxcECeqH11y8sGG/kRUTpwCZ7KwKakhBN?=
 =?us-ascii?Q?1zqJQRra7db/X2Bf8UkygZEuhO99PlZnqI8JtD7jP3S29Ep6oKplT4VlvtLD?=
 =?us-ascii?Q?bh518sHTh0qgsgn7HuP3DbsDruhoXo+btoWO8kaeTxgL3BXk4FSTDIDcYXKf?=
 =?us-ascii?Q?JU21sLku+1VZHmzNHTNJj61VljKFOuay3O3pzOtxSYrC+n/2Hs6uPejQlYEr?=
 =?us-ascii?Q?NyN7OMDystrl3B2Vphf0xUNrI/rQJkzppLfmVon5apEFtPncb1Zn4j8OB6ns?=
 =?us-ascii?Q?1w6torLHS7FP+bDFJyzdeeJRX49/zXgmS7IsTodymrbdNUPN6H2uKRVQRX75?=
 =?us-ascii?Q?rNEx9B925C2n1aRzEzFCdqCWvEns9EEbbtHuf+94qK0giyLmDewu3PNf2Mqw?=
 =?us-ascii?Q?36ajDf1zZn0V8PvzUBTWWRgSCDrjSO48+mUk1/xAmTzFnw+6ispFmJpkoPj1?=
 =?us-ascii?Q?5ztPXSjBSNnQUpt+P0LgDn4Fl6DpFHn+0l2gYNwpIt8c9/g9m3O3qcWutZH4?=
 =?us-ascii?Q?l3fSPQJ3YfOnzqgLxwBQXooh6dXRoN/m9stkepzN2pKYytVLq3H8GFbvNJ8N?=
 =?us-ascii?Q?IzYy5LjSQR48dabL2wtmxUfZWOS3SY7z+Bac01L3vPSMjWpcms9d6cMM6Xhz?=
 =?us-ascii?Q?bhe/x3R72zIx1nLIjZVRFufNTc37U7rA1fxqtDsXq40z5Ie/q90Y7RsPxDj2?=
 =?us-ascii?Q?itYtIL3Vxa+OlzAB4Nd/KYkiWZrOhgKRtN6nbM7oWKwaa1J1Wo9m//KNc2vc?=
 =?us-ascii?Q?XdEBzVsYIVI/th53mMhkOIjJuA7mKxuhEiyZv6MqNniTvJjzgwj52pnpfvUU?=
 =?us-ascii?Q?RqIz2ieZkprxvwF18saXmDFHSsc+6kNytOO0mcsDDU3eV1VaKpTAOYk98H2z?=
 =?us-ascii?Q?xgk6ugCaMrAm/rDUHLQXVkZLMUDC6tyGPFpqoeQODntiz2AWxPfdrHRJGeH3?=
 =?us-ascii?Q?17cDWjG5303F1mFZX9Bn0FTZQIhxZnFVV2r0/jw1Zp3mUkECDLM2ADLYF4Ew?=
 =?us-ascii?Q?iq4Qg038PXKIBZlyx83ABfiPbJ7ZoQpaFF7Q5ZMhPI5uJhtmbxvr/H/DgAS1?=
 =?us-ascii?Q?Jhp6siqn63jSQ+1hn5pqGvJa6qzcZ3c0HOunRYIjyG4RMCkFovqktDb1leJ7?=
 =?us-ascii?Q?L0KIeYVv9ZefT1OjPk+x1r9r0RIZ0pQF4rxCelfzbW2OoTTGHAdcW5NTbIuZ?=
 =?us-ascii?Q?9558NyFZhDGu/cw1nWGWG6B7gOcgfAN/tJRW8DLUJNJ8SGQN2E5qwJKbvfsM?=
 =?us-ascii?Q?SConjTGqcrgjRFUBZyQvMZSnu01jtTBWE36YMHU5ufnC5Ss3qbKPbvnWt041?=
 =?us-ascii?Q?PjbrzOE9lRgH6w9hA9zbvZlpNWf0SVuOJIYLspJYJl+fAaWUKtgSZ+Lzwizt?=
 =?us-ascii?Q?16knWMb+WA9K4bQhM6/qzAt7u+5uMcjI+N+aRxlifvTSx0F4yFfgzvIn8Son?=
 =?us-ascii?Q?VsYkx8sQA+M5IJp4rHWLNA2h535sRwfCyOsmZcyUcsuO8erbx3NOC5EIl5Gx?=
 =?us-ascii?Q?mae2oBr3N5C0bCfSTcAZSQcshgvK5WnObvFhrvVPmMedTCJC3VTSTokkGPep?=
 =?us-ascii?Q?UYeyTKZ5YrwihLF8gAR6+Tf2Q7BWw9FYc/VwRqVKQW5QtHAi5HL8gXfQGEHQ?=
 =?us-ascii?Q?1/rjLqIUeuw3sGeJdacdyPl4MXjdIwlGZ6A/Hh9UUe9JMJBD+mjTCvZsuh5+?=
 =?us-ascii?Q?uzdCwzwcdsR1/YI+Udm5dic6Iu4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b84fe80a-ca32-4d86-3b81-08d9a4e67c7b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 07:40:09.0628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IulZMYOh5Xp607Tutw2pKfQaOsTRGUqdmaFTmlnqL2QSBRbECbVFLOejR4c7kxUUVgFZHnxiFpBY0R3p6VWCQjRo6R9SP1Vpqoj0ttFt3WU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4610
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10164 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111110044
X-Proofpoint-GUID: WfiayfbySW9SXGDLpuenMm1vzqk6d2mj
X-Proofpoint-ORIG-GUID: WfiayfbySW9SXGDLpuenMm1vzqk6d2mj
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 11, 2021 at 10:33:41AM +0300, Dan Carpenter wrote:
> On Wed, Nov 10, 2021 at 02:31:47PM -0800, Mark Gross wrote:
> > On Wed, Nov 10, 2021 at 10:43:46AM +0300, Dan Carpenter wrote:
> > > This code should be using PTR_ERR() instead of IS_ERR().  And because
> > > it's using the wrong "dev->client" pointer, the IS_ERR() check will be
> > > false, meaning the function returns success.
> > > 
> > > Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > >  drivers/platform/mellanox/mlxreg-lc.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c
> > > index 0b7f58feb701..c897a2f15840 100644
> > > --- a/drivers/platform/mellanox/mlxreg-lc.c
> > > +++ b/drivers/platform/mellanox/mlxreg-lc.c
> > > @@ -413,7 +413,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl
> > >  				int size)
> > >  {
> > >  	struct mlxreg_hotplug_device *dev = devs;
> > > -	int i;
> > > +	int i, ret;
> > >  
> > >  	/* Create static I2C device feeding by auxiliary or main power. */
> > >  	for (i = 0; i < size; i++, dev++) {
> > > @@ -423,6 +423,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl
> > >  				dev->brdinfo->type, dev->nr, dev->brdinfo->addr);
> > >  
> > >  			dev->adapter = NULL;
> > > +			ret = PTR_ERR(dev->client);
> > ret is only set on this error path.
> > can we get to the return without setting ret?
> > 
> 
> No.
> 
> :P
> 
> There two ways to read that question is if the patch introduces an
> uninitialized variable bug and I would be super embarrassed if I did
> something like that with all the QC scripts that I have to prevent it.
> The other way to read that question is if it's possible to not introduce
> the "ret" variable but instead figure it out at the end.  But the error
> code needs to be preserved at this point because we change change the
> "dev" pointer and set "dev->adapter" to NULL.
                         ^^^^^^^^^^^^
I meant "dev->client" not "dev->adapter".

regards,
dan carpenter