Message-ID: <16fbb472-4a82-1267-9971-db453ba009e3@canonical.com>
Date:   Thu, 11 Nov 2021 10:56:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH] ARM: s3c: include header for prototype of
 s3c2410_modify_misccr
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20211111091123.50853-1-krzysztof.kozlowski@canonical.com>
 <CAK8P3a3MezegptR_-XPVm=RtOn4UYsb+TPEKjCGb-XRt9ke36A@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <CAK8P3a3MezegptR_-XPVm=RtOn4UYsb+TPEKjCGb-XRt9ke36A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/11/2021 10:46, Arnd Bergmann wrote:
> On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> Include the header with prototype of s3c2410_modify_misccr to fix W=1
>> warning:
>>
>>   arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>>     no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> Thank you for fixing it,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> If you like, I can put it into the fixes branch of the soc tree directly,
> otherwise I expect you'll send it in a pull request later.

It's not a serious bug and was there since long time, so maybe let's
send it via regular pull request.


Best regards,
Krzysztof