Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A85DC4321E for ; Thu, 11 Nov 2021 10:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8519961215 for ; Thu, 11 Nov 2021 10:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232854AbhKKKGt (ORCPT ); Thu, 11 Nov 2021 05:06:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57684 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232705AbhKKKGr (ORCPT ); Thu, 11 Nov 2021 05:06:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636625038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgI+Fga244qRdHsv3NfTmj/X0PIXJLU6JdJEs2Lnikc=; b=faDHT2GCPeamj3341q69FIyWgPzPlifrnJS3jd0fIoKVOMgnpvCn8OBW60nqXrck+5ka19 ADVu5evIotKGZ6hTnnvQ5ZukaXe30IQAHRYMPGmOnhdh3IqrogY3NjJyU2YXUB+egTwga2 ycO9iAHnolbqbqMBNwisQUaa3+BiYgQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-2vmURocMOIG6a6bt1h04lQ-1; Thu, 11 Nov 2021 05:03:57 -0500 X-MC-Unique: 2vmURocMOIG6a6bt1h04lQ-1 Received: by mail-wm1-f72.google.com with SMTP id g80-20020a1c2053000000b003331a764709so4551285wmg.2 for ; Thu, 11 Nov 2021 02:03:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=RgI+Fga244qRdHsv3NfTmj/X0PIXJLU6JdJEs2Lnikc=; b=a3IMCv8MbTf8ij9nK56fTQr4oMSIxTtJyjBbxLpwIrN6D1OTFEuVzzxhFnqgQgev5j kWuSBuT0U8+Br9djqmtSKvqkgv1skexBwqC6D0Kjo6pAdlQSSAtm9tobVUUehUJX7yeS vpZ73ZWlyO+wpJCK75e+zivSi8z0GeQMi6HnkdpyZ68ifDGvx7FvpxeULjOrM4P8tI11 C9Dpnd6tj9Dy81wsKqbACarBzkt7C8b7p11Wi0AEUSTNPD+I6+c0mVczHNsO2x7AnBNN URJ9EgfZFn3QFLARVAHW0WKdFgBeqckJhsV7KuFCoqhSfB5ivAbv23F48b4hkL3rpesk M5TQ== X-Gm-Message-State: AOAM530E0GDh840D7tppuPrNYdTyB7wfEtGiB55g/KsWX+uYoRIrRwfF TtQJFyUG/3JhyDlGm9cmJdxcVr2Ee9pn1A+siDfFbZAq/w/ATa1tWVPiAIQSJDdMtRU6JzUWuaj 8Hf/CILudBP7BUWDSi81xWozq X-Received: by 2002:a05:600c:202:: with SMTP id 2mr6795104wmi.167.1636625036004; Thu, 11 Nov 2021 02:03:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbEOMfOu1BPHyGDT4lSs2gwzkWRkK6yYNIJ1XKpWm1ValPzCs+UlG7aY+RgLlSJjV/OSwWfA== X-Received: by 2002:a05:600c:202:: with SMTP id 2mr6795079wmi.167.1636625035774; Thu, 11 Nov 2021 02:03:55 -0800 (PST) Received: from [192.168.3.132] (p4ff23ee8.dip0.t-ipconnect.de. [79.242.62.232]) by smtp.gmail.com with ESMTPSA id h3sm2362194wrv.69.2021.11.11.02.03.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 02:03:54 -0800 (PST) Message-ID: Date: Thu, 11 Nov 2021 11:03:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 4/7] fs/binfmt_elf: use get_task_comm instead of open-coded string copy Content-Language: en-US To: Yafang Shao , akpm@linux-foundation.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Petr Mladek References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-5-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211108083840.4627-5-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.11.21 09:38, Yafang Shao wrote: > It is better to use get_task_comm() instead of the open coded string > copy as we do in other places. > > struct elf_prpsinfo is used to dump the task information in userspace > coredump or kernel vmcore. Below is the verfication of vmcore, > > crash> ps > PID PPID CPU TASK ST %MEM VSZ RSS COMM > 0 0 0 ffffffff9d21a940 RU 0.0 0 0 [swapper/0] >> 0 0 1 ffffa09e40f85e80 RU 0.0 0 0 [swapper/1] >> 0 0 2 ffffa09e40f81f80 RU 0.0 0 0 [swapper/2] >> 0 0 3 ffffa09e40f83f00 RU 0.0 0 0 [swapper/3] >> 0 0 4 ffffa09e40f80000 RU 0.0 0 0 [swapper/4] >> 0 0 5 ffffa09e40f89f80 RU 0.0 0 0 [swapper/5] > 0 0 6 ffffa09e40f8bf00 RU 0.0 0 0 [swapper/6] >> 0 0 7 ffffa09e40f88000 RU 0.0 0 0 [swapper/7] >> 0 0 8 ffffa09e40f8de80 RU 0.0 0 0 [swapper/8] >> 0 0 9 ffffa09e40f95e80 RU 0.0 0 0 [swapper/9] >> 0 0 10 ffffa09e40f91f80 RU 0.0 0 0 [swapper/10] >> 0 0 11 ffffa09e40f93f00 RU 0.0 0 0 [swapper/11] >> 0 0 12 ffffa09e40f90000 RU 0.0 0 0 [swapper/12] >> 0 0 13 ffffa09e40f9bf00 RU 0.0 0 0 [swapper/13] >> 0 0 14 ffffa09e40f98000 RU 0.0 0 0 [swapper/14] >> 0 0 15 ffffa09e40f9de80 RU 0.0 0 0 [swapper/15] > > It works well as expected. > > Suggested-by: Kees Cook > Signed-off-by: Yafang Shao > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- > fs/binfmt_elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index a813b70f594e..138956fd4a88 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -1572,7 +1572,7 @@ static int fill_psinfo(struct elf_prpsinfo *psinfo, struct task_struct *p, > SET_UID(psinfo->pr_uid, from_kuid_munged(cred->user_ns, cred->uid)); > SET_GID(psinfo->pr_gid, from_kgid_munged(cred->user_ns, cred->gid)); > rcu_read_unlock(); > - strncpy(psinfo->pr_fname, p->comm, sizeof(psinfo->pr_fname)); > + get_task_comm(psinfo->pr_fname, p); > > return 0; > } > We have a hard-coded "pr_fname[16]" as well, not sure if we want to adjust that to use TASK_COMM_LEN? Anyhow Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb