Subject: Re: [PATCH] drm/amd/display: Clean up some inconsistent indenting
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        alexander.deucher@amd.com
Cc:     Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1636625005-87952-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <abc4159c-e903-9265-826e-b44b387a7fcf@amd.com>
Date:   Thu, 11 Nov 2021 11:08:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <1636625005-87952-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWZKd0hKNUJtY1hqa2JUak5jZHIxUytJOTVHZXJuNHhPa3Z4NTNXaFhCaUw5?=
 =?utf-8?B?enVLWWtTT21TY05PRE5KOUJ3Qzg0QitqaEk4eTZNYzVScHNuNUR5NG1RK1lk?=
 =?utf-8?B?T1VLS3lHYWg4TFlPT21BRkJFdmFYZ2d6cHE3bW5PaGUvK0RWbE9SREVuaHFw?=
 =?utf-8?B?S2FRcDFJU0hUMG4xSExYUDlZNnFQcjV4QWwyOWo0VzZRQzZaWkFWOWUzaGYy?=
 =?utf-8?B?cVVvdFNWZDN3THlmT3hsTFVmRndYY1BDNm9Mc3pVeCt4aElLZStuOC9lWWtw?=
 =?utf-8?B?ajRoaktWZDRRNlhrQ0JUd2wyRmExd3BNMGYwSTNMS1VUWmp6cU1VTnowb0M4?=
 =?utf-8?B?QWF6aUovalBjMk12WWhTWTFIRVBYTk94di9ZSFh1SnRENjhkQTFLNHlzNlhk?=
 =?utf-8?B?VGozYnJ6ZTZoY3hGZ29sZExiMy82em5UbjFZckQzKzVHa0I0WHZ6eHBCbnhr?=
 =?utf-8?B?bThJNFlSTEM1bmg3ZjNrWlYvNGhpK0h3d09CZlpvOTVodEFoZ25Jdm94SFZQ?=
 =?utf-8?B?RW11KzMwRDRGVUI5ZG1NYjRwREJUVjBzazRXTlhPb2hqeEJuTklwRXV4Q21O?=
 =?utf-8?B?QzRtL2hMeUV3cTdDTXhlVnNCSmRIazNwUTZPdWJEZGY2eVp0RFowTU1IeUVM?=
 =?utf-8?B?NGhQU1VTWmtHa2hjd0J1RlU1UmF3WG5hdnRaYTBZYm52bzhRaHpjTXF1ejFk?=
 =?utf-8?B?T09HNjQ4MUc0YUR4VlhrNUVmVDlPY09NWUVRTFZWZVowQkZHVlRvQnhGZCtp?=
 =?utf-8?B?LzlXcVp1SjVocFhGdGgxR2NmSU5UVmd6SWRkdEdsLzkzNHJMTlk0NEpMczBT?=
 =?utf-8?B?SzkrS2ppdWlqWGM3d0VRYWVNYkJjVDhEUWh5bHpWVUdRUmUyM1Y3c0JaMjlQ?=
 =?utf-8?B?Y1d4K2tPRk94a0lrWU9Wa01WcmEzemd2ejNWRU1wZlg2d3ZObHg3V1hXWDRM?=
 =?utf-8?B?RW5mT21FSE1qTGpvaEs4ZC9TUTQ3ekk1eHYySzh6S1ZJVFpFR01GMzFNYVZr?=
 =?utf-8?B?aktCQ01kRzBFMGl6azlDdDNXdVhQZDNjczF3OEhKREduRWs0eXRlS2RmMlg2?=
 =?utf-8?B?UGFsbWdCQTNqL0VhNGlZcUtVaDhvdHFzTnc2WmJodGR0bFlMakp4cUlld3NU?=
 =?utf-8?B?NHE1b2NUYzIzamZjVGNIVnB2NzR2RkEyOWlLRVRSVDNGaFV4T1JZd3Zaa0Zi?=
 =?utf-8?B?V0t0aURGakV0MkZGQ3VSaVFkWnAwUFYxQkN2eGVXR3ZuZHRsM2hRUkdGM3Ar?=
 =?utf-8?B?TVB2Z1EyclJxd1lRM3JRYkQ0T2kwUzFlSjJ3emNyN25jMmdmZWJ5aVVUY05l?=
 =?utf-8?B?M3lTd2l4OFNHMzVzSXhHSXY2MzVMSkYwUUdvNTBHTDVkejZ6MW1zZEM3OGMz?=
 =?utf-8?B?ZDNyQnZTQ1h5UlJkSmFuTmFuTXJJVEQ1VkFSQW5PVndUYU85RDhuQ1ZNdWlS?=
 =?utf-8?B?UTk2VnJXWUdHS2lESFZWRWtnN2I3RUwzb01JaWh5TFM4NHV5WG1xVEJvRXQz?=
 =?utf-8?B?QlRrRUZVVm93d25iUHJYQmhNNUtMa293OElTamFRWFFIZUVucWtLWndJNGN5?=
 =?utf-8?B?ckNkM1NjSnVsTHNDc00rZFdYM0RJRFlFRFNPa01ISk1kMWZFQktUZzhiL1da?=
 =?utf-8?B?SkJhREhQUE92VWdHM2dOOWRTY2I1amRnNk9xV2hnc2tvNFZQb1FLT29SbFNP?=
 =?utf-8?B?TjdkNjlnbWJwU0RrLzBkcVQrRnJUZGM2YUYzTjk3UTFsazhadVN1ZE1qb2dl?=
 =?utf-8?B?SWIwL2l2T0gwcFBWQUpJNUtCZmpSU1Z0U1FBOVpFUTFhSyt6Y3dmcEpZU0dF?=
 =?utf-8?B?Tmt6UUFFRG9jcmI0eEFLdVV3ZmxaZjZYSndDd3FvOW9heXRuYXJNM0ZTaTF4?=
 =?utf-8?B?WHNWZitUcG4wRUJYbWFUdytYTnpPejJjRndPN2t0V0hFUitPcXU0Uyt2N1Ew?=
 =?utf-8?B?VTg0QjdCdDVnTXZ5U2NJdHAwZFNMVWZET2FqQ1dNSGZNV1dCdm5DeVlBY0tY?=
 =?utf-8?B?QlNtclNpWWtLbENsc0hlU1JzZXFHTVUxdFEzZUxkenZKanZUWmhMVlhaK3N0?=
 =?utf-8?B?MmtvSUNGQWcwZHlMMHZmNDg4cU5SK21qdEh5cnQrajNMWjBEY2tielNuUE5U?=
 =?utf-8?Q?FKUA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbef5118-9e50-4ec6-0fea-08d9a4fb45bd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 10:08:56.4710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dnYd7NSTqsLbv8g404mQIm8rLHCW47ScqTzt71rilMH2KO/+JpN/tp40BmmGer6+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4586
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 11.11.21 um 11:03 schrieb Jiapeng Chong:
> Eliminate the follow smatch warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:622
> dmub_srv_cmd_execute() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
> index 56a0332..e9fadf1 100644
> --- a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
> +++ b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
> @@ -618,8 +618,8 @@ enum dmub_status dmub_srv_cmd_execute(struct dmub_srv *dmub)
>   	 * read back stale, fully invalid or partially invalid data.
>   	 */
>   	dmub_rb_flush_pending(&dmub->inbox1_rb);
> +	dmub->hw_funcs.set_inbox1_wptr(dmub, dmub->inbox1_rb.wrpt);
>   
> -		dmub->hw_funcs.set_inbox1_wptr(dmub, dmub->inbox1_rb.wrpt);
>   	return DMUB_STATUS_OK;
>   }
>