Date:   Thu, 11 Nov 2021 12:38:26 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavankumar Kondeti <quic_pkondeti@quicinc.com>
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Felipe Balbi <balbi@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Peter Chen <peter.chen@nxp.com>,
        Jack Pham <jackp@codeaurora.org>,
        Dean Anderson <dean@sensoray.com>,
        Salah Triki <salah.triki@gmail.com>,
        Andrew Gabbasov <andrew_gabbasov@mentor.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] usb: gadget: f_fs: Use stream_open() for endpoint files
Message-ID: <YY0Asjnm/Ce6FpS8@kroah.com>
References: <1636629117-2206-1-git-send-email-quic_pkondeti@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1636629117-2206-1-git-send-email-quic_pkondeti@quicinc.com>
Precedence: bulk

On Thu, Nov 11, 2021 at 04:41:55PM +0530, Pavankumar Kondeti wrote:
> Function fs endpoint files does not have the notion of file position.
> So switch to stream like functionality. This allows concurrent threads
> to be blocked in the ffs read/write operations which use ffs_mutex_lock().
> The ffs mutex lock deploys interruptible wait. Otherwise, threads are
> blocking for the mutex lock in __fdget_pos(). For whatever reason, ff the
> host does not send/receive data for longer time, hung task warnings
> are observed.
> 
> Change-Id: I602fa56fb5ed4c8c46e19df68c3335c4b12cae81

Always run scripts/checkpatch.pl on your patches so you do not get
grumpy maintainers asking you to run scripts/checkpatch.pl on them...

thanks,

greg k-h