MIME-Version: 1.0
References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <6864f744-ca3e-f328-8793-2adb0146db03@bytedance.com>
 <CAHP4M8VNZY+NLzUAVHTWK6a6pggvv4a-q9nvYAqkkco6id3Tog@mail.gmail.com> <CAMZfGtXCFJ3NUw-bBsphLbCtdDAfHERAEkTSMU9k1cfd4DrRMA@mail.gmail.com>
In-Reply-To: <CAMZfGtXCFJ3NUw-bBsphLbCtdDAfHERAEkTSMU9k1cfd4DrRMA@mail.gmail.com>
From:   Ajay Garg <ajaygargnsit@gmail.com>
Date:   Thu, 11 Nov 2021 17:51:05 +0530
Message-ID: <CAHP4M8UY0F3gx0eVYGKHfcoN-=f6ApT0CjA3xsZRrb3HVphK6A@mail.gmail.com>
Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>
> What? I put "if (PageHWPoison(page))" into the else branch,
> it should be added braces since it's not 1-line blocks.

Oh, ok.

> Why do
> you think it does not address the issue? What am I missing
> here?

That might work, however I haven't tested it.

Upto the reviewers to see what they see as the best way going forward.


Thanks and Regards,
Ajay