To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfw2g7xr.fsf@ca-mkp.ca.oracle.com>
References: <20211104182201.83906-1-axboe@kernel.dk>
        <20211104182201.83906-5-axboe@kernel.dk>
        <YYQoLzMn7+s9hxpX@infradead.org>
        <2865c289-7014-2250-0f5b-a9ed8770d0ec@kernel.dk>
        <YYQo4ougXZvgv11X@infradead.org>
        <8c6163f4-0c0f-5254-5f79-9074f5a73cfe@kernel.dk>
        <461c4758-2675-1d11-ac8a-6f25ef01d781@kernel.dk>
        <YYQr3jl3avsuOUAJ@infradead.org>
        <3d29a5ce-aace-6198-3ea9-e6f603e74aa1@kernel.dk>
        <YYQuyt2/y1MgzRi0@infradead.org>
        <87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk>
        <alpine.DEB.2.22.394.2111111350150.2780761@ramsan.of.borg>
Date:   Thu, 11 Nov 2021 08:19:18 -0500
In-Reply-To: <alpine.DEB.2.22.394.2111111350150.2780761@ramsan.of.borg> (Geert
        Uytterhoeven's message of "Thu, 11 Nov 2021 13:58:38 +0100 (CET)")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PjxjVhSQS5CYlqHbpHYeMiErq7eO0JJzacO4a50slE1gAu/sMsBn2Nn201iG?=
 =?us-ascii?Q?T8k48F4KHuT3GDTJmZr44tlrTBfXCxD0rEp223zoEwYlACZtEVbw4aumdtpB?=
 =?us-ascii?Q?/t0+VJw9uxmAPDfEaR3dGI8rwiFaa7CG8TU9X3+h0ZMD28FEU/ctrwPF/AGX?=
 =?us-ascii?Q?c0wSFOcoh8SL391zrcVxB0CSxQGA1OLtMVryEmeA/uZS48CeWMQoReVtAsvb?=
 =?us-ascii?Q?nL73bRaDhfYJQB1vRzcYUDRews7TAGqmEybVxZgiaNnkZF/7+JskLPtXjxDR?=
 =?us-ascii?Q?gaZA5wE1ijzEjk0PS7OsQ7KrJkBHvbf6jyxKBCu9gDjs7pPzpgzxcDRYAxIj?=
 =?us-ascii?Q?vlCo7PT8KNZoehYlUjEnxBY+d5qxJbU6OorbVIcl8XWjX5kBuF+qb3m1O4zo?=
 =?us-ascii?Q?JOTlf4QoDpztyoFLigTpci8j/iU/4O4ez1mz5ZtGwqXv6OrbajRXI27N7Ujp?=
 =?us-ascii?Q?bY7/3hPa4FsLyhcjTeEVn5CgQK20QJN2tWme4yYWDmE+XtsV0OExKf9gcJu0?=
 =?us-ascii?Q?7DJy/kehW7IKdRK0jwQI1SVKCap3AfeYATOBOko4cW5DIPtd3/+SPz/7LaeK?=
 =?us-ascii?Q?PAhIffRE+diZmr+Ad60L8C2T1NVWJlxe3LolkGmKR03j6cT80pZGO5ZbvVxx?=
 =?us-ascii?Q?0LYbnCvEOz/Kml29U1cDNDLjZPuHf+YWibhrJ20oesiNpZQ+xhWJgNywvT/8?=
 =?us-ascii?Q?iR0t9+oGiUzSLeOPCzKQrGcA1GU6wUvle6X/gPNg3iE/64u3Zv6SnLT44vKm?=
 =?us-ascii?Q?7CvbKvJ03OZRnUH7akGfS61K+5v5TqxdKsVfQyAZBhoQXaZ4NybKqMzKsdCW?=
 =?us-ascii?Q?UxK+dWKtvWcypXU0cw7Bhi8TRNgFLJwI5d+YEFI1t3vVYIHKQ5jr5MezdIpu?=
 =?us-ascii?Q?Y5jr4bPqRDtVHbQ/V/q7JI7Uoz8EdB4XB7zbEwUm5Uz4WF4b58EsMn88HegE?=
 =?us-ascii?Q?0amoEcka+PMHt+B958GP31WmnOp/Bb7bZkiyZmemETfIVk6b/n7zp0FoRCb7?=
 =?us-ascii?Q?XXN/WXfwhgROT+ME8yuY9sWyQV6gA7GdcCxKRRiq4QYJoVq5IOeApv7boPDg?=
 =?us-ascii?Q?DnQgWTY4nVf0Ss8IWgZVD1+WWcEfN+IZpYe5zFY7dUbl68Iah3Qa9LrcosUC?=
 =?us-ascii?Q?2BJfOx+Lh1m8sUkGbSphkB2JRjblTKaXeQMzpSS5HUW0SXM+30DFxaQ8VQDr?=
 =?us-ascii?Q?6UdaC5ZBQBaLCGnO6N2uog3U/9RW4SCJuLapKlefPuj++vjBANS7DWLtBQGk?=
 =?us-ascii?Q?xEZ8j1GFOoyfPZqqvH/2ug48/QJydqZIoFlX/QUMhLxFisxl0EieNXVNWceI?=
 =?us-ascii?Q?GXyiQNAYRmmkX95MfhlskdsqECR4ljpZivBp6gH4t37pCy6wlwfV7W8WANCC?=
 =?us-ascii?Q?jh7LNwS2SXHRWFI/R/vdGea4NDJLhpGgZUNYJ9yawCgBeIwDtKgbTFpnly8Y?=
 =?us-ascii?Q?tCfk1cEGMHqXqp0MrDmqfvLkaMGA/5NTZ6fC5aafWa7rmIobfYzhJrAYByaw?=
 =?us-ascii?Q?ZK/vNDtNoCKZuOmsEzc5XRHFSCaAR/fcBbHkrwtPHf3wRNejLN1NKFzZMmyn?=
 =?us-ascii?Q?rt/Nlr2AX7v3atW1DkQBOjklMBMQe0sU1kKj2V6k414oAEgY421nPsHJ86vK?=
 =?us-ascii?Q?GfbGUZxF2ivDaEsWdMzb0ryqEdb6MhLaeuM4hZav6veVPNTiUdP4b1vIDAYV?=
 =?us-ascii?Q?lHtL0w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba18a987-ed40-45c9-89a8-08d9a515deea
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 13:19:20.4336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PwzskDM3FyZP4cG79TNK1B7swPLrsHbi1OVGOo//BPIQhCN+u5ym3jVSvlWsNEmtIdDlRoAtsQeLAZZIuEpOrPcK2nj+EpJuM+grqflZSfA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5484
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10164 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=898 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111110079
X-Proofpoint-ORIG-GUID: X7v38xWPfnPIH8RhP_cX9hrDNT2cBY5B
X-Proofpoint-GUID: X7v38xWPfnPIH8RhP_cX9hrDNT2cBY5B
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Geert,

> sd 0:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
> sd 0:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current]
> sd 0:0:0:0: [sda] tag#0 Add. Sense: Invalid field in cdb
> sd 0:0:0:0: [sda] tag#0 CDB: Write(10) 2a 08 00 00 00 01 00 00 08 00
> critical target error, dev sda, sector 1 op 0x1:(WRITE) flags 0x20800 phys_seg 1 prio class 0
> Buffer I/O error on dev sda1, logical block 0, lost sync page write

Peculiar. That write command looks OK to me. I wonder if it's the FUA
bit that trips it?

What does:

# dmesg | grep FUA

say?

-- 
Martin K. Petersen	Oracle Linux Engineering