Message-ID: <b91c26d828b24479369fa1f17d8d03c324b5bebd.camel@linux.intel.com>
Subject: Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build
 error
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     YueHaibing <yuehaibing@huawei.com>, rafael@kernel.org,
        daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 11 Nov 2021 06:51:21 -0800
In-Reply-To: <20211111070716.20260-1-yuehaibing@huawei.com>
References: <20211111070716.20260-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In
> function ‘send_mbox_cmd’:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
>  error: implicit declaration of function ‘readq’; did you mean
> ‘readl’? [-Werror=implicit-function-declaration]
>     *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base +
> MBOX_OFFSET_DATA));
>                 ^~~~~
>                 readl
> 
> Add missing include to fix this.
Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig
to 64-bit"?

Thanks,
Srinivas

> 
> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal:
> Suppot 64 bit RFIM responses")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> index a86521973dad..01008ae00e7f 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> @@ -7,6 +7,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/io-64-nonatomic-lo-hi.h>
>  #include "processor_thermal_device.h"
>  
>  #define MBOX_CMD_WORKLOAD_TYPE_READ    0x0E