Subject: Re: [RFC PATCH 5/6] kvm: x86: add KVM_EXIT_MEMORY_ERROR exit
To:     Chao Peng <chao.p.peng@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        Hugh Dickins <hughd@google.com>,
        Jeff Layton <jlayton@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        luto@kernel.org, john.ji@intel.com, susie.li@intel.com,
        jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com,
        david@redhat.com
References: <20211111141352.26311-1-chao.p.peng@linux.intel.com>
 <20211111141352.26311-6-chao.p.peng@linux.intel.com>
From:   =?UTF-8?Q?Mika_Penttil=c3=a4?= <mika.penttila@nextfour.com>
Message-ID: <f7155c5b-fc87-c1a6-9ee7-06f08a25bdb4@nextfour.com>
Date:   Thu, 11 Nov 2021 17:08:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211111141352.26311-6-chao.p.peng@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWRDNFJnL29hSk10N2JNSmxJdXRPWStNRnY5TXBLTlNjbEU5TVJVcVkzUzhr?=
 =?utf-8?B?T3ZrbE96bk1jRFNGeHJBSWlKVzFsNllvdnhBY25XcnZxNEVESnExK3BIVThu?=
 =?utf-8?B?Y0dXQ01SWEJ5Y0xVMnBEY0djdzFjMXFFWmg3U0w0bTlZM2JRbVFFcEVBdlZu?=
 =?utf-8?B?RHpOV3hyRktkY092WGQ1R29QeHFtZHczb2UwVVpJVDRKaHBma2RyNDZjUkhK?=
 =?utf-8?B?ZG45eExCNjkyY3lEWTRCRmJmUlhNY0dDVmFpbHdqbVBOQlpqcmMrRS80SVJX?=
 =?utf-8?B?cTJvMGNURU9tdzcxMW9xaGVZdVovTStUbWUwN0RBRTB4enkxMmpsZUpYVXBR?=
 =?utf-8?B?eDdLNXo2RjNtT1crcmZtN0R5d0E3OEI4b1lhRDFoM3UwdS9NTXZKYWRiVzJt?=
 =?utf-8?B?Uk55MHpmWkh6T0xTSVpDVEtjSWtjVEpsWm1nQmFaV0NDSkRNRCsxRGdCdVBH?=
 =?utf-8?B?eVhjeGhtYi91c3JaTVBzN0FKRk81MGRhQlhzd0I4Slk4RHRUNzVsQ2t6MG1s?=
 =?utf-8?B?VlJXUjYzYklnVTIvTlQ0bVZ6UFRLSUxRME5NS3dPbkpUMWlsTjFvK01QQUVN?=
 =?utf-8?B?KzZrYnlkcmdlMHlja3dIblRXYlRIR3dHMGVydlZldXE3YjRXMWZPN1U3OEl0?=
 =?utf-8?B?WDhoQXZndU1IbjJIeWkveitsdm5Qc3pNMStybko0MGhlMzBmOXJJUmlxSWFw?=
 =?utf-8?B?MFFvd2hEMFFXT2ZrT2swWUpkSTNOS3NFUDRReVB5aFBlZ3RmSjhUZmlTTXN3?=
 =?utf-8?B?dGpwNE8xMnZGS25FZlJBMWtuSTFXdEg0QUxleGNGZFVVV1FFT1RJM1hDd2lG?=
 =?utf-8?B?QWNWSHJmblhRVzRRZjBsSkg2VUhTSzNUVlpZc0pmMmZ3aDJiZEVkNDdzbFdR?=
 =?utf-8?B?a1lJRWJ2YW5mcENrR1VremFXejBtM1BoTFhyWnFKTjFjQ3FrTFQ2WGU1bnEy?=
 =?utf-8?B?eWdiOC91Mm9acndrNzFNUXNkT1RsdGN0VmoxNkRZTnZBcktzekY5dyt3Rmw2?=
 =?utf-8?B?b2pxK3JTWERLMDNLTWp0VE41cVByb29XOVc4NEpNYmVPem50RkRPekJmZW9v?=
 =?utf-8?B?M3VKbkEydWNMbUF6M1VuN1RnVkFnZVp6ck5DWUlSUEFrQko1b1Y1VFpOTE0z?=
 =?utf-8?B?K25Sblh4VTh5aFZ4SU82dVF1VGdHdGtyTm96aDJ5MXh5Tkw1K2N5dGVRV20w?=
 =?utf-8?B?WFlxeElLejg5NzNETkhvbC9nYjh0YkR4TnF6VjJDbGVrd2tGZlVycTRJQ1lK?=
 =?utf-8?B?Q3NYRTVyVmhSdVJhK3NRMHR3NnJ4Vmg0THg5dDlxQjlOQm1zUlhqM2xzV0Ix?=
 =?utf-8?B?UERETjlsMS9QOVRBVVVaREtIRmxJYkdmajFEeUVBMWpKZzZRVkNWOVgzRG81?=
 =?utf-8?B?WkJVMWFyVGZPVUV6QzVmdXB2dytCa2RMdE5zdDVyQ00rVUE0UW8wN3VVWEJQ?=
 =?utf-8?B?R1lEWVg1RFd0U0wzenl1ZUJCMDZqTUJxMDJSUXNialBHVDEzYjMrR3FOSjk1?=
 =?utf-8?B?eE9TTTFqUWxNVXJjaGgzQTUvNHhpenExbEg3dUdSRVcyUTRCNFNRVXBKL0NM?=
 =?utf-8?B?b3NyOURjQjJyajhSeENXYVFOcEhCWnBvS0YyU0NjZzQ5RXdRVGRRWVp5d1lW?=
 =?utf-8?B?SkZDUUwyc0MvWStiaGh6UEZLeFlQUUlWYzFHY1EyajV6Ri9PSWFOM08xckZy?=
 =?utf-8?B?elJEbVQ5ZWkwcTNEUkE3ZnQ3VGdVUzFwd0IyQ25TZ2w4d1A5bE5ISjEvZFdk?=
 =?utf-8?B?MUJlSmxEbGlqdkU1ejNIdFFETnFpRzRQZC90S1pJYS9Zd0oxMTlIMUV5eHFQ?=
 =?utf-8?B?Wm1ZUzZIZ0dXcXJHdHU5ZFhlTVlZQzRXY0RiMmRHc0gwVXFxdTRNQi9iN0ht?=
 =?utf-8?B?dnlISUxrbU1RcTBxYnJzR29vUFp6WnJ0UHFFZytIRk1rYmZVYURvdXIwZGVr?=
 =?utf-8?B?cW80NXdBeENkc2lGWjh5cXVBQ1g5QVlsMWtBS2tWOXhzMW1lWSsrbldPdEQw?=
 =?utf-8?B?eTQzaDNYN0JOc2RFODhmc0cwUC91aHJwVnU2K0hPN092MzRIazJrUTE1dlpP?=
 =?utf-8?B?NSt3SHMrd2xuTE5tNjZ4eU1nSEZ6K1VZaFFmY0xleVhhRjB3ZDZ4ZzNUMWNG?=
 =?utf-8?B?cExjdFRxNG5LdUY2cldxRGswcVNpRzBjcXhkaGVxWmNKYlNsRWwwcUJVcXkw?=
 =?utf-8?B?VXYydFZlMVdBc1JxWnk4ZUVzUUZ5TWNMViswUTFnUklWZkNpV2JOQmxYRmJU?=
 =?utf-8?B?bEt5Q3l0dVRWWXlvTExGY09SNUx3PT0=?=
X-OriginatorOrg: nextfour.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa8fdd53-dac8-4ae7-6811-08d9a5252bee
X-MS-Exchange-CrossTenant-AuthSource: DBAPR03MB6630.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 15:08:52.2119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 972e95c2-9290-4a02-8705-4014700ea294
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cR7DnEkqbCvUwfVTHP9piMh7t5Mvr9tvardi2QlTkKDMWj2d9kTRu7pXTjIDO0vcU4vxfeAlISYbwwvQAdv46oq4PwZAEPMwHPoOrBnAQWM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4555
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11.11.2021 16.13, Chao Peng wrote:
> Currently support to exit to userspace for private/shared memory
> conversion.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> ---
>   arch/x86/kvm/mmu/mmu.c   | 20 ++++++++++++++++++++
>   include/uapi/linux/kvm.h | 15 +++++++++++++++
>   2 files changed, 35 insertions(+)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index af5ecf4ef62a..780868888aa8 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -3950,6 +3950,17 @@ static bool try_async_pf(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn,
>   
>   	slot = __kvm_vcpu_gfn_to_memslot(vcpu, gfn, private);
>   
> +	/*
> +	 * Exit to userspace to map the requested private/shared memory region
> +	 * if there is no memslot and (a) the access is private or (b) there is
> +	 * an existing private memslot.  Emulated MMIO must be accessed through
> +	 * shared GPAs, thus a memslot miss on a private GPA is always handled
> +	 * as an implicit conversion "request".
> +	 */
> +	if (!slot &&
> +	    (private || __kvm_vcpu_gfn_to_memslot(vcpu, gfn, true)))
> +		goto out_convert;
> +
>   	/* Don't expose aliases for no slot GFNs or private memslots */
>   	if ((cr2_or_gpa & vcpu_gpa_stolen_mask(vcpu)) &&
>   	    !kvm_is_visible_memslot(slot)) {
> @@ -3994,6 +4005,15 @@ static bool try_async_pf(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn,
>   	*pfn = __gfn_to_pfn_memslot(slot, gfn, false, NULL,
>   				    write, writable, hva);
>   	return false;
> +
> +out_convert:
> +	vcpu->run->exit_reason = KVM_EXIT_MEMORY_ERROR;
> +	vcpu->run->mem.type = private ? KVM_EXIT_MEM_MAP_PRIVATE
> +				      : KVM_EXIT_MEM_MAP_SHARE;
> +	vcpu->run->mem.u.map.gpa = cr2_or_gpa;
> +	vcpu->run->mem.u.map.size = PAGE_SIZE;
> +	return true;
> +
>   
I think this does just retry, no exit to user space?


> }
>   
>   static int direct_page_fault(struct kvm_vcpu *vcpu, gpa_t gpa, u32 error_code,
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 8d20caae9180..470c472a9451 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -233,6 +233,18 @@ struct kvm_xen_exit {
>   	} u;
>   };
>   
> +struct kvm_memory_exit {
> +#define KVM_EXIT_MEM_MAP_SHARE          1
> +#define KVM_EXIT_MEM_MAP_PRIVATE        2
> +	__u32 type;
> +	union {
> +		struct {
> +			__u64 gpa;
> +			__u64 size;
> +		} map;
> +	} u;
> +};
> +
>   #define KVM_S390_GET_SKEYS_NONE   1
>   #define KVM_S390_SKEYS_MAX        1048576
>   
> @@ -272,6 +284,7 @@ struct kvm_xen_exit {
>   #define KVM_EXIT_X86_BUS_LOCK     33
>   #define KVM_EXIT_XEN              34
>   #define KVM_EXIT_TDVMCALL         35
> +#define KVM_EXIT_MEMORY_ERROR	  36
>   
>   /* For KVM_EXIT_INTERNAL_ERROR */
>   /* Emulate instruction failed. */
> @@ -455,6 +468,8 @@ struct kvm_run {
>   			__u64 subfunc;
>   			__u64 param[4];
>   		} tdvmcall;
> +		/* KVM_EXIT_MEMORY_ERROR */
> +		struct kvm_memory_exit mem;
>   		/* Fix the size of the union. */
>   		char padding[256];
>   	};