To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        linux-block@vger.kernel.org,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11r3mg1gm.fsf@ca-mkp.ca.oracle.com>
References: <20211104182201.83906-1-axboe@kernel.dk>
        <20211104182201.83906-5-axboe@kernel.dk>
        <YYQoLzMn7+s9hxpX@infradead.org>
        <2865c289-7014-2250-0f5b-a9ed8770d0ec@kernel.dk>
        <YYQo4ougXZvgv11X@infradead.org>
        <8c6163f4-0c0f-5254-5f79-9074f5a73cfe@kernel.dk>
        <461c4758-2675-1d11-ac8a-6f25ef01d781@kernel.dk>
        <YYQr3jl3avsuOUAJ@infradead.org>
        <3d29a5ce-aace-6198-3ea9-e6f603e74aa1@kernel.dk>
        <YYQuyt2/y1MgzRi0@infradead.org>
        <87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk>
        <alpine.DEB.2.22.394.2111111350150.2780761@ramsan.of.borg>
        <yq1sfw2g7xr.fsf@ca-mkp.ca.oracle.com>
        <CAMuHMdVdwwT5yQPpQ5Frr-Un5OMk9LX3sF_zocOejrouSjaO-w@mail.gmail.com>
Date:   Thu, 11 Nov 2021 10:36:07 -0500
In-Reply-To: <CAMuHMdVdwwT5yQPpQ5Frr-Un5OMk9LX3sF_zocOejrouSjaO-w@mail.gmail.com>
        (Geert Uytterhoeven's message of "Thu, 11 Nov 2021 15:48:37 +0100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YMV/k95mmL+OxBp69luya5x9MuvTiFg+oKbummovmDAd0jBcT+c36gmOFtTE?=
 =?us-ascii?Q?EqBIgu0GMfLxb0YmmzxBjSyTSmyU2YulYK5u9xNTac39Xz3siP4mHj04/Zve?=
 =?us-ascii?Q?E5Bj646EoQ0rbcH3yn8JVE3qUCa56Iw6DXg53nFKTNXLCrkeYw1rlYi0tRJ6?=
 =?us-ascii?Q?mFDu9BrIr8/WrTDIrtP5ceQhBknSlIaTnUXVLVAqSjTojptzGn41FQeoBmAX?=
 =?us-ascii?Q?1LNTpsoW+c7PvRSnNNyKg9dmSO/ApTZW4tHKBSiC1G5wI+b0TV8FtD0h3sAs?=
 =?us-ascii?Q?99TWKb1lMZdECoF8n7gE4K8b2DqAnOO1Rze9z0V+sNOrZvoRnteEOAzS9Bpk?=
 =?us-ascii?Q?UWaIdKe9kPqPlRI6nhweja9BiRc2KEwPWnA8VS/zluQ73O+Wcy9waiPTxlz+?=
 =?us-ascii?Q?MjtWbcs3RIiSiH6Qbj8kL/6SVl3XVhaFUc1XoY3bM73PJI5xynoopE3q/o+z?=
 =?us-ascii?Q?6ae3Qp3BL9BCYG+EAsKCoMASRyZrXzIP48IXAseNe6duBZpIyY7hDrDpAb4h?=
 =?us-ascii?Q?YFwYin5DzXlhGfevjWEh/QxJvU32h055vurHERXrJ0g839km8RlY3ezUmVD3?=
 =?us-ascii?Q?udrRIN4PCqR3Cc5KxphjXyxxSpnAlSR9wtRtRTgzwYJb+VtFOhN16LvqPcpZ?=
 =?us-ascii?Q?S+eZaDg86NcArQmwdeJ5jaAywB1S+/BXT9eFdhZSfMan66jJ8H7oTDcScW1Z?=
 =?us-ascii?Q?MZ5YUCMbgU5+ozv65ADF6uSEfHusX/4mynm8jsYMcRODPOQMuMUCa8ORWVdL?=
 =?us-ascii?Q?8NpXpmadXuMfAdq5WhqopDVbmSa/JDaOZ1RN8oie4B8xF34TIQyUMIM9U9Ft?=
 =?us-ascii?Q?YtEBYcjNtHCa6UsmQ5sAxEBiUrkSlhPqcU4e96U87M9GE3I6f6eGhDKkpYjx?=
 =?us-ascii?Q?S3b/FGkLowBaXS/4uurksn/oBaBenx2hsIK/eJ4bIFGo3aTsnDTK47fAziLW?=
 =?us-ascii?Q?ZsovEjjTTmRzh49lCTA0bE/s64tG6sfVfkM4F0ZmCg6VpnPsQczu/c5peLmM?=
 =?us-ascii?Q?WpLXkfdX8mhqNOlzjIqeUO4+wlKXPGIf5zqdu9OjJB72ppK8wlZxqV9lrNTy?=
 =?us-ascii?Q?QUm44tkx6HRsftgqJTSagDN6Ze0QL616IGKDQNuGT9K2K82ABhLBu1m/hBuL?=
 =?us-ascii?Q?gAldGRFfyJFaynX7rxd0XoZ4fHu0DpbAOee2jHgobLkApTlDgUZgMRQoJI37?=
 =?us-ascii?Q?750Fom629/La71ntxL20nYUFOz+Xb42F7WJ/RlTcOgzyvczLzHYuxgSh9kY9?=
 =?us-ascii?Q?eYrFkAS8E/7M1lFku5Cr9/XYYcbWoDl4m7vCnhPof1ZXeBAuBkEOYsTYGUfB?=
 =?us-ascii?Q?47ilmHDNsFXaLVM/l40g2kTIMydvYoxF+5COFhCR5cXUnxHn5vPnLii+Iwoc?=
 =?us-ascii?Q?5dt7TGYmm5cPHVNGeEyNhj2EWAeDjROVbxsU5c3HoFMUXOmhTcY4QZKIYUbO?=
 =?us-ascii?Q?rSZJrxhznINpaCACwfQzLRymtHdPwdTxAdJpyfZw/011VkwBmFQ93Pfq2X1i?=
 =?us-ascii?Q?kT/UDgcDjSc6P4wupwePubIoVYuB48+cjyXY4wpefid9+mWtlmNQY51NeeN4?=
 =?us-ascii?Q?p31IQ6IntTpGftI0Z9zxhKzwMqFyVUeiLdXPqvv6KsubM2pux6cRL0KGpxMO?=
 =?us-ascii?Q?G1sb9S8+AELu7B1EyfHlZLmRg6dmDkW1S0ubFMAcektcqx1Y4MymgpUAguxa?=
 =?us-ascii?Q?7905Qw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25779599-e0e6-4525-597e-08d9a528fb9a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 15:36:08.9401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xGYjJ62oMp3vpbZhAeqUV4lJmdKKnKYSYYvIRKQx8ZmIkPwmfNvr40ZCMkDLLzzdyDdvtGb5Tv8x289kVYyL6MhDjfnVTtNMcbtZpT49i5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5513
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10165 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111110087
X-Proofpoint-GUID: qbsYTe3_DJg32Uu5yDvpglmPrglBEaIR
X-Proofpoint-ORIG-GUID: qbsYTe3_DJg32Uu5yDvpglmPrglBEaIR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Geert,

>> > sd 0:0:0:0: [sda] tag#0 CDB: Write(10) 2a 08 00 00 00 01 00 00 08 00
                                               ^^
                                               FUA

> sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't
> support DPO or FUA

The device is correct in rejecting the command, then. But I'm not sure
how the commit in question would cause us to inadvertently set that
flag...

-- 
Martin K. Petersen	Oracle Linux Engineering