Subject: Re: [PATCH 1/2] KVM: SEV: Return appropriate error codes if SEV-ES
 scratch setup fails
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211109222350.2266045-1-seanjc@google.com>
 <20211109222350.2266045-2-seanjc@google.com>
 <fc56edb6-5154-4532-242f-4acb8b448330@amd.com>
 <b13cdd98-52b7-f70b-5aad-5f8ca6413bc0@redhat.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <3bd2d4f8-1077-6f57-ece6-13354f1f5ede@amd.com>
Date:   Thu, 11 Nov 2021 09:56:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <b13cdd98-52b7-f70b-5aad-5f8ca6413bc0@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vy9QSFU3NXF2bmRNZGVjSDIveS9PeGxnb0plSWtLUFFuS2w2ODk5aWZMTjRG?=
 =?utf-8?B?Z2Njc1A3YmFMQ1ZPN0cxaEVzb1ZnWEpmQWE4N3Yxd282WWtaMllyM0k3L3lE?=
 =?utf-8?B?QVJ6Q1B5UXorQjA3TUxnK09obGJmWUxtS0lBb1YxaWFkZmdISGFqbHpUeFJo?=
 =?utf-8?B?ZUloOFl2bFZFVmpYeElYNkllUUkvckxXMUhUdjJZb3ZHNEVSdHhhcyt6L2dl?=
 =?utf-8?B?dkNRUTZrSXJwek9SRk52WlhBY21RS0tQbExsNFF4MzlDQk43VlZvNW9YNHpM?=
 =?utf-8?B?Vk9DdEtTSzBPeE4za2xMY1VKeDEwTUhJRmRrTm9jMEJFYXBxNjBLRk5HeG1S?=
 =?utf-8?B?KzJQTlFJWStOZG9mU2ZQUWxPeURrR1h5SDZGc1BqcXI2TlRnYW1yZnZBSzNB?=
 =?utf-8?B?ZlloTnVRd1Q2NVdsR3hrcUtEMGVzZW9IenR1K1hQbWJreDRmWEhHdDdpZnlj?=
 =?utf-8?B?SFZZN0dwempmSFVmV2w0SExQRlozd2xOZzdRZndYdFI4eWlFYmtZTkVmQ0dq?=
 =?utf-8?B?em1aMERhdU05bnFpWkdodm1YYlRQeWMrMjY1MnF3K1VVdzB3b1FOTnBScVlp?=
 =?utf-8?B?SWxZdmRZN1VVcUdGUktZdFBTcDZaYkZwdTFwekZqRHV2THJqTGxGSFpyanRu?=
 =?utf-8?B?Y0FnWDR6cFVRc09oWDJOY0F5NXh3Qk5pVjJOOUNJRlI4ZTJVeUdVSlZqYXY0?=
 =?utf-8?B?TTdBYkc4U08yUU04TlVwcFR4TnhEVWZBdnZQbkg2TzlzNVdValFqTkFhN29M?=
 =?utf-8?B?OE9yeHd2NjRlSVI4MTFzSzAva1QxdWczMzBFa1hvTWJ2S3loek9LTm1ESWJM?=
 =?utf-8?B?SWg0bVR3aUFLUXJGbkxnTCtPN25aeE5yMHJCZWtsaVhDQmlMWkJPQStVdEJE?=
 =?utf-8?B?N3Fqb1R1MElSMld0ZTEyRlZFT3hOS2UzclpLSzFaS1hUcTR6WXkyaEpKZ0pp?=
 =?utf-8?B?SWpMWkZuTVEwRVhlWVY2M1pIa05pQ1k3bEtYbFo2UkZkd3NCZTMxQzBXSENx?=
 =?utf-8?B?OW9uN3hzUWpEZ1RadHNYNlFJZXI2UGo5SHhHMVpZaGI5b21YejlXOUdsbVVj?=
 =?utf-8?B?Z2NXcnNFdWtTS25HbkNvbVFscUZuU3ZIaE5QbVFTRUw3bjJlZ1JNMGdYZzVT?=
 =?utf-8?B?SUNpZDBRV3ZJcmhGM3BvZnRCTGdpUHlpOXFtdlpnTEZWeDE1TEx6VzN4UVBo?=
 =?utf-8?B?WkhKaDNSKzVPcm5USVlDd0pzRmxnWXFYRHJuQS8xQXE0T3Nldm1YZ0cxNnpU?=
 =?utf-8?B?Njk0bzQ3OXV5R2Jzb2EvSUFBeEIvV0QyZ3Y1OE5nTVVrQTVhWGRGR3Vlc2gw?=
 =?utf-8?B?TVdTNFUyaGdoS0dORktLVDRyc3pVZklxVUJWd0MwTTg0ZHNNemV5cFNNbmNw?=
 =?utf-8?B?REo0Yys3VUhmdmE1eGJZOUVkQkVUMHI5Mmc2bzRidHhPaUY0ckdCZldMQnZQ?=
 =?utf-8?B?SVYrRFpVY2pFQmNXY2ZyNkYwTGRKYlRoaUxTa1dZbUoyd3hTT3NhSm9JQVJx?=
 =?utf-8?B?ZGRxVE1zYTNyeFJuMFo5a3pJUXNrQnZLRW9vR0hvTk9keTBOdGlZTCtramE5?=
 =?utf-8?B?WGRHNWxCenEvK0EwNVdWY2VSNHJ0aS9leE4vVXhUZFh0VFl0ZDVJbjEvM3VJ?=
 =?utf-8?B?V3dueW9VbTBySUgyRExKL3QrbUFkeGp2M1graCtweE56ZmlYdkkxV3hZa0tv?=
 =?utf-8?B?ci9ZUWxRSGZuWWVIM3pVVHA2UG9OVlBkSFVvSXVlZFoyN25kaE93dW91cmUw?=
 =?utf-8?B?VUp4VzNTSUZGVU1HemFxWGh3YTdvQWMwK0JMSVBRUmU0bnBFUU9RaVRxT3U3?=
 =?utf-8?B?QjJzbEpmZFA2WlphSUs5Y3JrNUYvMGxQSmZSTStxTUEzNHh3WXJwT0tocnlk?=
 =?utf-8?B?UkNzZzJBRE95RGk4OFEzTXp5eWYvN0NTZ0RFRkhLVGx6K2FKN1FnSlJPbDh5?=
 =?utf-8?B?YjVocjdOVFlacDBGek8wU1hBV0h3RitlWmxLSEhHUW84SkY1RTlPOVR6VDJT?=
 =?utf-8?B?YmJmNWcyaTdBN0szbFoydUJlMTJVU21Ha2pqYW9nNFlKU2lwK3dJY2VHQkFN?=
 =?utf-8?B?S2ZTeFBwZ2ovWFl6blZYRlA1QTJEZGxONU1kdzNIYnJRZEgwQ3lQSTFnVHMw?=
 =?utf-8?B?VmEzcDJZOFd6c01jN0VWNERwRlVrNTU4S3NPTmpJaDFURXlocXJkVGRqWGVL?=
 =?utf-8?Q?h5szJmYh3diKBjK9QNyiLCc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8a3ac41-0117-4c98-c1ff-08d9a52be368
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 15:56:56.9107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQd4bfSn8fajglrXiqYwguL6KzwraNOWizTzElnXtERfK/bOpvO2/uSO9Xzks25mqr37fSMr7l1NYjIVhmbyLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5296
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/11/21 9:47 AM, Paolo Bonzini wrote:
> On 11/11/21 16:14, Tom Lendacky wrote:
>>
>>> Return appropriate error codes if setting up the GHCB scratch area for an
>>> SEV-ES guest fails.  In particular, returning -EINVAL instead of -ENOMEM
>>> when allocating the kernel buffer could be confusing as userspace would
>>> likely suspect a guest issue.
>>
>> Based on previous feedback and to implement the changes to the GHCB 
>> specification, I'm planning on submitting a patch that will return an 
>> error code back to the guest, instead of terminating the guest, if the 
>> scratch area fails to be setup properly. So you could hold off on this 
>> patch if you want.
> 
> I think we still want these two patches in 5.16.

Ok, I'll rebase my changes on top of these then once you push them.

Thanks,
Tom

> 
> Paolo
>