Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD0AAC433EF for ; Thu, 11 Nov 2021 16:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CBE16124C for ; Thu, 11 Nov 2021 16:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234154AbhKKQM5 (ORCPT ); Thu, 11 Nov 2021 11:12:57 -0500 Received: from mga17.intel.com ([192.55.52.151]:30729 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233940AbhKKQMz (ORCPT ); Thu, 11 Nov 2021 11:12:55 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="213663626" X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="213663626" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 08:10:04 -0800 X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="534447537" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 08:10:00 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mlCe5-005nYt-Ji; Thu, 11 Nov 2021 18:09:49 +0200 Date: Thu, 11 Nov 2021 18:09:49 +0200 From: Andy Shevchenko To: Tsuchiya Yuto Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nable , Fabio Aiuto , "andrey.i.trufanov" , Patrik Gfeller , Hans de Goede Subject: Re: [PATCH 04/17] media: atomisp: pci: do not use err var when checking port validity for ISP2400 Message-ID: References: <20211017161958.44351-1-kitakar@gmail.com> <20211017161958.44351-5-kitakar@gmail.com> <20211026092637.196447aa@sal.lan> <1a295721fd1f1e512cd54a659a250aef162bfb6f.camel@gmail.com> <20211028123944.66c212c1@sal.lan> <20211101141058.36ea2c8e@sal.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 11, 2021 at 11:34:23PM +0900, Tsuchiya Yuto wrote: > On Mon, 2021-11-01 at 14:10 +0000, Mauro Carvalho Chehab wrote: > > Em Mon, 01 Nov 2021 22:38:55 +0900 > > Tsuchiya Yuto escreveu: ... > The full output of the make error is here: > > ("NOTE: issue: some undeclared errors") > https://github.com/kitakar5525/linux-kernel/commit/a932d16681f941161385659b9d0316a3a4975e86 I just realize that we may do at some point cflags-y += -Werror to avoid changes that breaks build (with warnings). And also I would suggest to run build with `make W=1 C=1 CF=-D__CHECK_ENDIAN__ ...` -- With Best Regards, Andy Shevchenko