MIME-Version: 1.0
References: <20211111091123.50853-1-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20211111091123.50853-1-krzysztof.kozlowski@canonical.com>
From:   Alim Akhtar <alim.akhtar@gmail.com>
Date:   Thu, 11 Nov 2021 21:58:35 +0530
Message-ID: <CAGOxZ50Fs1YZcCY+Go-4KqeeqdLRcwJwEHuXdDX8tTL7nWsttA@mail.gmail.com>
Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Krzysztof,

On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=3D1
> warning:
>
>   arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>     no previous prototype for =E2=80=98s3c2410_modify_misccr=E2=80=99 [-W=
missing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/mach-s3c/gpio-samsung.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-sa=
msung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
>  #include "gpio-core.h"
>  #include "gpio-cfg.h"
>  #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
>  #include "pm.h"
>
>  int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>


--=20
Regards,
Alim