Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page
To:     Ajay Garg <ajaygargnsit@gmail.com>, hughd@google.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20211111084617.6746-1-ajaygargnsit@gmail.com>
 <CAHP4M8V2WEQ0LgHp7PHdBMYFp+_frn=7GLQVF7=faqapojQ+2g@mail.gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk>
Date:   Thu, 11 Nov 2021 10:59:09 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAHP4M8V2WEQ0LgHp7PHdBMYFp+_frn=7GLQVF7=faqapojQ+2g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/11/21 10:45 AM, Ajay Garg wrote:
> Another report of the issue (different call-flow, but the same error
> at "shmem_read_mapping_page_gfp") at :
> https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m52d98b6bdb05764524a118b15cec048b34e5ca76
> 
> with a tentative approval for the patch :
> https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m24c2888a879d428cde5b34c43838301de544eb7e

Andrew, I've hit this multiple times on resume on my laptop, and it's
a very apparent bug in that b9d02f1bdd98 commit that it doesn't factor
in error pointers. My oops clearly shows it being one too, with ...fff4
being the dereference address.

Can we get this pushed upstream asap if you're fine with this patch?

-- 
Jens Axboe