Date:   Thu, 11 Nov 2021 15:57:18 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Jim Quinlan <jim2101024@gmail.com>
Cc:     linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com,
        Florian Fainelli <f.fainelli@gmail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/8] PCI: brcmstb: Change brcm_phy_stop() to return
 void
Message-ID: <20211111215718.GA1353371@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211110221456.11977-2-jim2101024@gmail.com>
Precedence: bulk

On Wed, Nov 10, 2021 at 05:14:41PM -0500, Jim Quinlan wrote:
> We do not use the result of this function so make it void.

I don't get it.  Can you expand on this?

brcm_phy_cntl() can return -EIO, which means brcm_phy_stop() can
return -EIO, which means brcm_pcie_suspend can return -EIO.
brcm_pcie_suspend() is the dev_pm_ops.suspend() method.

So are you saying we never use the result of dev_pm_ops.suspend()?

> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index cc30215f5a43..ff7d0d291531 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1111,9 +1111,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie)
>  	return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0;
>  }
>  
> -static inline int brcm_phy_stop(struct brcm_pcie *pcie)
> +static inline void brcm_phy_stop(struct brcm_pcie *pcie)
>  {
> -	return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0;
> +	if (pcie->rescal)
> +		brcm_phy_cntl(pcie, 0);
>  }
>  
>  static void brcm_pcie_turn_off(struct brcm_pcie *pcie)
> @@ -1143,14 +1144,13 @@ static void brcm_pcie_turn_off(struct brcm_pcie *pcie)
>  static int brcm_pcie_suspend(struct device *dev)
>  {
>  	struct brcm_pcie *pcie = dev_get_drvdata(dev);
> -	int ret;
>  
>  	brcm_pcie_turn_off(pcie);
> -	ret = brcm_phy_stop(pcie);
> +	brcm_phy_stop(pcie);
>  	reset_control_rearm(pcie->rescal);
>  	clk_disable_unprepare(pcie->clk);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int brcm_pcie_resume(struct device *dev)
> -- 
> 2.17.1
>