From:   "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Subject: Re: [PATCH v5.5 29/30] KVM: Wait 'til the bitter end to initialize
 the "new" memslot
To:     Sean Christopherson <seanjc@google.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        David Hildenbrand <david@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-mips@vger.kernel.org, kvm@vger.kernel.org,
        kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ben Gardon <bgardon@google.com>, Marc Zyngier <maz@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Anup Patel <anup.patel@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20211104002531.1176691-1-seanjc@google.com>
 <20211104002531.1176691-30-seanjc@google.com>
Message-ID: <676299e2-a59b-2af0-7e6a-b2b47b7765e0@oracle.com>
Date:   Fri, 12 Nov 2021 00:52:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211104002531.1176691-30-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UG5NQnZYSmNiZVZmYyszUWJ3cVZDTlZvV2FXQjNHdzdLMkRIZjBrWWkxSzNI?=
 =?utf-8?B?d1J4TFgrSWZaeThtK3dSc1lpalpSaTBKSmtLMGZ6OHdvSkp3QXh2bkMvZG5a?=
 =?utf-8?B?RjhzVjFEVDR5RmxpaWs0Z3paeXg2R3d1UTdXVU5pcnpDM0FiRGpaQWdiR2U3?=
 =?utf-8?B?WnpEbkJYVGY1QjFyT1dXWlIrM1JqcU9ZNHo5OXNvV0NEcGRQNERJcjRCT0kr?=
 =?utf-8?B?dm5CajZ5SVlpWlU1WkpONTk4Smkxd0grYU5jZHcwOTJab1FoQlNDRFRvSkVB?=
 =?utf-8?B?NmFhWm9MS3llVnFWRlZZWXlBcDh5OFBJalBjOWp6eEdFS0JqZ1pDQlNSRTRn?=
 =?utf-8?B?VHl5K0k5MFZJOG1OdmMrZ2dGRmZacWVPUDkwK2lZUWFHUWo0NGZDbGVRVGM3?=
 =?utf-8?B?b0RmSXphUnZaM3NZK1c1UjcwNFIwVlRvdkdRZDZTc1BFUDQzUlR2YTU1R0xV?=
 =?utf-8?B?WEdJY0JyaVNROTdxQ204MlMxcUJ0NEhuTHJjUzhSVVNRcGVNWURrSnNvWVox?=
 =?utf-8?B?NjRMeis1YUR6aElxekNZSWtZWkltRFYzYjlPbk5IZE1vRk1lYmtrdkVmN3Y0?=
 =?utf-8?B?MXgvNitMeHdTOTB3Mm5lQzdsZ0RyZkowN3g4bkZzM2YrK1FqUEpTMS8zUUhI?=
 =?utf-8?B?NWYydllLVHVnOWx2VzFMdko5SGg5VGVNR2hvTExMT3U1bFUxcG5CVG8wbXNH?=
 =?utf-8?B?c2NVdUxMZHQ3L1ByRmRqb0xuRVhWNHpvSzR1cDU3dEVLY0tuNnRpY0owdzI1?=
 =?utf-8?B?WGVkTlorS2gvNEdjVExYUzRTL21SYU5qdXM4NEpEZnB2Kzc0TzI5SmNPUldp?=
 =?utf-8?B?ckxiTzF6d3VRd0VmeXRKWmhiWlB4dWVWV0gzdTVEWW1zYS9LaitsSGM5TEk2?=
 =?utf-8?B?WjEyRXRMai91eElES2tQVXZZcWlFeW1GWGZ5Mml1L1ExSUhGeFZjczdJMENh?=
 =?utf-8?B?bkZrNjJ1b2J1UURTbjlMNHdVajJXQlF6Y2FkMzljMFFneFlPWWNrUzlTR0NP?=
 =?utf-8?B?aFBLQUIxZjNLcUV1aXBFSzg3Yk43ZTJ4TTcwUlJpS2VyRk9uV0luWElVOW01?=
 =?utf-8?B?dlF0b3dvL202ZTBNcVFaOEVUYWlBaUE1TExCVngrVW80R3ZrdVVySDVQOG54?=
 =?utf-8?B?ZWUxaG1oRHhvM3BWckliMitKekpOZlY1Z3U2MldoVnd0c2k1MFdBcGlvRVNL?=
 =?utf-8?B?ald0aDBNVGRNRUpDdmRuQkZ3YlNyN3N4YW9ERnJYNDJMRWh1NkNpQXV1czFH?=
 =?utf-8?B?aHJBQVFtSzl5N01MdjYwU3Rqc0l3MEo0MmZNUUp1ZmFnRWR1S3V0SjFjTUU2?=
 =?utf-8?B?T0V2eDJ1U0VOaUlzSmkvdmc2SE9tbklFNUtkVStqbXlSZHRFRG1wSisyMWRs?=
 =?utf-8?B?YTh2QlJkL2ZYNXFteGREZlBzWkZYMXh0UE53WTBncmFLdEZONW1xMEIwMlB4?=
 =?utf-8?B?RzFyRy9PSW1RK1BBTHFGNjVpakw3UzNPR1dnMUxNREtUaEFYZGpVMytEMklO?=
 =?utf-8?B?ZzJnUUVJWm5PdWl3SGh4N2hNNnMzMkg3T2FZQXNIcVNWb2FCWUc4OE9BdGhK?=
 =?utf-8?B?ZVd4eVlleG5nNXNBLzBDOVB6Sk1VaUxOc2NzT3VRQ01Hb0FrMWZYRXhmaXhT?=
 =?utf-8?B?VVl0VTc0QVNUOXNFSG9XUmNrSks5SmUwKzdTZ3Q5STBQNWJ6anlBdWtXblNv?=
 =?utf-8?B?SGNwcytxWWtKSGFYMTQ5aVFIUFU1emYwbjVveEUrL0lOUTZHT0cvNXg3bkZY?=
 =?utf-8?B?WDB4bXNhWStXdlRlQW5UM1ppT0xGZmd2dlEvVkQzd2V4SVgyZXlCcmZyaCtM?=
 =?utf-8?B?QXpXV3UyeUsyWkFLUWwxcXhDYXlCY2JFcm4zdEtUZnc4RkRCblBVSmdEYUli?=
 =?utf-8?B?eHFHSlYxLzhSbDE4UndoUGJIeEc0b2YvNkpJSzZkWjkwQlRRUVBubzd5UFFF?=
 =?utf-8?B?ZjNiT2s3NXUyblgzM2dJSHpOWjN2SjV4UlphbUtkbjJhZTRXN0Q3QjBuRVNv?=
 =?utf-8?B?WDZTU2kvTndPV1lRNkRnaGl0TnBFbzk2MUlscHVjUnJUdE9QbG5WaHl0OER6?=
 =?utf-8?B?TGNOM29VbmJGbjZXM1VLdzFpY1V2bDNCd1BOR2RNUG1KNCtFVmJqSXd4VnBS?=
 =?utf-8?B?Q2NlU1RBaHJaOE0wK2FQd0J2NTY5WllJWWdQRVllVUVUbEpXZElpVU5NN01o?=
 =?utf-8?B?V2RUZ0o3Q3hxL3lWd3RGZmUxemJnVmRwWmIyU3ZQYnl0QXBaM1I4MVlkRHVu?=
 =?utf-8?B?NVJQdWw1YVBNcG9Qck1WM05LdlV3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6890edbc-7c16-4957-10f3-08d9a56e62f0
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4008.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2021 23:52:57.7509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rk1TYQTRl3FXLJdXcj+YlwbLs2W4y3A5NSzDhetcjph5bv32uONNfOwMFVwWDMjZg5jFsuCPTVdTX0nrRTK2UzJO2jFcvCt1KphJB3wAxTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4938
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10165 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111110121
X-Proofpoint-GUID: zYyuHJp-p1-qKv2tSkrkBBgqDcllPmCx
X-Proofpoint-ORIG-GUID: zYyuHJp-p1-qKv2tSkrkBBgqDcllPmCx
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.11.2021 01:25, Sean Christopherson wrote:
> Initialize the "new" memslot in the !DELETE path only after the various
> sanity checks have passed.  This will allow a future commit to allocate
> @new dynamically without having to copy a memslot, and without having to
> deal with freeing @new in error paths and in the "nothing to change" path
> that's hiding in the sanity checks.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>