From:   Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To:     <mathieu.poirier@linaro.org>
CC:     <bjorn.andersson@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-remoteproc@vger.kernel.org>, <mark-pk.tsai@mediatek.com>,
        <matthias.bgg@gmail.com>, <ohad@wizery.com>,
        <yj.chiang@mediatek.com>
Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code
Date:   Fri, 12 Nov 2021 10:13:10 +0800
Message-ID: <20211112021310.19493-1-mark-pk.tsai@mediatek.com>
In-Reply-To: <CANLsYkyLgvMDx-CMLZPEdJ8rUuGX-=QgB++5fz_h_ordm_q1aA@mail.gmail.com>
References: <CANLsYkyLgvMDx-CMLZPEdJ8rUuGX-=QgB++5fz_h_ordm_q1aA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

> Hi Mark,
>
>
> >
> > Use %pe format string to print return error code which
> > make the error message easier to understand.
> >
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> >  drivers/remoteproc/remoteproc_core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index 502b6604b757..2242da320368 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> >                                            dma_get_mask(rproc->dev.parent));
> >         if (ret) {
> >                 dev_warn(dev,
> > -                        "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > -                        dma_get_mask(rproc->dev.parent), ret);
> > +                        "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > +                        dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
>
> Macro ERR_PTR() is used to convert error codes to pointer type when
> returning from a function - I fail to see how doing so in a dev_warn()
> context can make the message easier to understand.  Can you provide an
> example?

Hi,

When dma_coerce_mask_and_coherent() fail, the output log will be as following.

format		log
%x		Trying to continue... fffffffb
%d		Trying to continue... -5
%pe		Trying to continue... -5	(if CONFIG_SYMBOLIC_ERRNAME is not set)
%pe		Trying to continue... -EIO	(if CONFIG_SYMBOLIC_ERRNAME=y)