Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21A4C433FE for ; Fri, 12 Nov 2021 02:16:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2AF360E97 for ; Fri, 12 Nov 2021 02:16:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbhKLCTQ (ORCPT ); Thu, 11 Nov 2021 21:19:16 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:26303 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233501AbhKLCTP (ORCPT ); Thu, 11 Nov 2021 21:19:15 -0500 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Hr2Br1zShzbhrh; Fri, 12 Nov 2021 10:11:32 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.15; Fri, 12 Nov 2021 10:16:23 +0800 Received: from [10.174.179.215] (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Fri, 12 Nov 2021 10:16:21 +0800 Subject: Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build error To: Srinivas Pandruvada , , , , CC: , References: <20211111070716.20260-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: <6446d19d-9580-c172-79c7-7cb40815cedb@huawei.com> Date: Fri, 12 Nov 2021 10:16:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/11/11 22:51, Srinivas Pandruvada wrote: > On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote: >> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In >> function ‘send_mbox_cmd’: >> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16: >>  error: implicit declaration of function ‘readq’; did you mean >> ‘readl’? [-Werror=implicit-function-declaration] >>     *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + >> MBOX_OFFSET_DATA)); >>                 ^~~~~ >>                 readl >> >> Add missing include to fix this. > Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig > to 64-bit"? Thanks for your info, the patch fix the issue. > > Thanks, > Srinivas > >> >> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal: >> Suppot 64 bit RFIM responses") >> Signed-off-by: YueHaibing >> --- >>  drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 + >>  1 file changed, 1 insertion(+) >> >> diff --git >> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c >> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c >> index a86521973dad..01008ae00e7f 100644 >> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c >> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c >> @@ -7,6 +7,7 @@ >>  #include >>  #include >>  #include >> +#include >>  #include "processor_thermal_device.h" >>   >>  #define MBOX_CMD_WORKLOAD_TYPE_READ    0x0E > > > . >