Message-ID: <9ee991e8-0d32-658a-8a9a-09a7d1d88ee8@gmx.com>
Date:   Fri, 12 Nov 2021 11:12:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] fs:btrfs: remove unneeded variable
Content-Language: en-US
To:     cgel.zte@gmail.com, clm@fb.com
Cc:     josef@toxicpanda.com, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        chiminghao <chi.minghao@zte.com.cn>
References: <20211112024950.5098-1-chi.minghao@zte.com.cn>
From:   Qu Wenruo <quwenruo.btrfs@gmx.com>
In-Reply-To: <20211112024950.5098-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 2021/11/12 10:49, cgel.zte@gmail.com wrote:
> From: chiminghao <chi.minghao@zte.com.cn>
>
> Fix the following coccicheck REVIEW:
> ./fs/btrfs/extent_map.c:299:5-8 REVIEW Unneeded variable
>
> Reported-by: Zeal Robot <zealci@zte.com.cm>
> Signed-off-by: chiminghao <chi.minghao@zte.com.cn>

IIRC the @ret is reserved there as we're not handling the !em case with
error number, nor is the only caller properly handling the possible error.

Thanks,
Qu
> ---
>   fs/btrfs/extent_map.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index 5a36add21305..1dcb5486ccb6 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -296,7 +296,6 @@ static void try_merge_map(struct extent_map_tree *tr=
ee, struct extent_map *em)
>   int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 le=
n,
>   		       u64 gen)
>   {
> -	int ret =3D 0;
>   	struct extent_map *em;
>   	bool prealloc =3D false;
>
> @@ -328,7 +327,7 @@ int unpin_extent_cache(struct extent_map_tree *tree,=
 u64 start, u64 len,
>   	free_extent_map(em);
>   out:
>   	write_unlock(&tree->lock);
> -	return ret;
> +	return 0;
>
>   }
>
>