Message-ID: <ea64e454-17c3-374b-67a1-f382cdf6c6a6@redhat.com>
Date:   Fri, 12 Nov 2021 10:35:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 4/7] KVM: SEV: Add support for SEV intra host migration
Content-Language: en-US
From:   Paolo Bonzini <pbonzini@redhat.com>
To:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     pgonda@google.com, seanjc@google.com,
        Marc Orr <marcorr@google.com>,
        David Rientjes <rientjes@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20211111154930.3603189-1-pbonzini@redhat.com>
 <20211111154930.3603189-5-pbonzini@redhat.com>
In-Reply-To: <20211111154930.3603189-5-pbonzini@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/11/21 16:49, Paolo Bonzini wrote:
> +out_dst_cgroup:
> +	if (ret < 0) {
> +		sev_misc_cg_uncharge(dst_sev);
> +out_dst_put_cgroup:
> +		put_misc_cg(dst_sev->misc_cg);
> +		dst_sev->misc_cg = NULL;
> +	}

Wrong (you must not uncharge if the dst_sev and src_sev cgroup are the 
same)  _and_ unnecessarily complicated.

I'll send an 8/7 patch as a fixup.

Paolo