MIME-Version: 1.0
References: <20210909150046.57615-1-ribalda@chromium.org> <CADvTj4rB5ZThAh2oPkx2=mqUir4Bc_uFFaL6DV_YyOYNSDrXEQ@mail.gmail.com>
 <CANiDSCvpRezQMEBbmv4z9ttPt9sThHXR2xmnizzacYuMDri-KQ@mail.gmail.com>
 <CADvTj4pAxGYeuQEN_ktHko41z=bCWWb1UtbdngezMoUUsvsj6Q@mail.gmail.com>
 <CANiDSCvkcr8hbdo4Ea2p3BdMPiPE2RC_HcHHmUdm9uy1XN2E4Q@mail.gmail.com> <CADvTj4r_SzChXj04Ddn6PPUDN7QnKczm6MJXeES-uUUQx3ds+Q@mail.gmail.com>
In-Reply-To: <CADvTj4r_SzChXj04Ddn6PPUDN7QnKczm6MJXeES-uUUQx3ds+Q@mail.gmail.com>
From:   Ricardo Ribalda <ribalda@chromium.org>
Date:   Fri, 12 Nov 2021 11:09:14 +0100
Message-ID: <CANiDSCsDWz5rS881NXXcuxJYb5RP=HLEmdQaYiKrjqyvhO223A@mail.gmail.com>
Subject: Re: [PATCH 0/4] Follow-up patches for uvc v4l2-compliance
To:     James Hilliard <james.hilliard1@gmail.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-media@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        tfiga@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi James


>Pixel Format      : 'MJPG' (Motion-JPEG)
>Field             : None
>Bytes per Line    : 0
>Size Image        : 614400
>Colorspace        : Default

>ioctl(3, VIDIOC_G_FMT, {type=0 /* V4L2_BUF_TYPE_??? */}) = -1 EINVAL
>(Invalid argument)
>ioctl(3, VIDIOC_G_FMT, {type=V4L2_BUF_TYPE_VIDEO_CAPTURE,
>fmt.pix={width=640, height=480, pixelformat=v4l2_fourcc('M', 'J', 'P',
>'G') /* V4L2_PIX_FMT_MJPEG */, field=V4L2_FIELD_NONE, bytesperline=0,
>sizeimage=614400, colorspace=V4L2_COLORSPACE_DEFAULT}}) = 0
>write(1, "\t\t\33[1;31mfail\33[0m: v4l2-test-for"..., 59 fail:
>v4l2-test-formats.cpp(358): !colorspace
>) = 59

Thanks for testing it out. In this case I believe that it is a camera
bug. The error is due to the fact that the colorspace is does not have
a valid value. That value is provided by the camera:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/uvc/uvc_driver.c#n766

You might have to send a patch with a quirk for your device.