Subject: Re: [PATCH v5 1/2] erofs: add sysfs interface
To:     Gao Xiang <hsiangkao@linux.alibaba.com>
Cc:     linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org,
        guoweichao@oppo.com, guanyuwei@oppo.com, yh@oppo.com,
        zhangshiming@oppo.com, linux-kernel@vger.kernel.org
References: <20211112023003.10712-1-huangjianan@oppo.com>
 <YY39YZcn/a6F0PMh@B-P7TQMD6M-0146.local>
From:   Huang Jianan <huangjianan@oppo.com>
Message-ID: <67b86422-3133-ff7b-ddb7-c25939bee549@oppo.com>
Date:   Fri, 12 Nov 2021 18:10:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YY39YZcn/a6F0PMh@B-P7TQMD6M-0146.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aCtqM1h4ekRHSVlQZWNuODhGS3NaTzNpVTVjTzJJUXFTWm84WFExd3psa2VX?=
 =?utf-8?B?ZXVQbVFxZVdRSnNoeldHbXVRMFZDSFNONk93b1RoT21acmw4cm9kTnNJNlVs?=
 =?utf-8?B?U2M4amFhTXB1Z3o0YVdrSlNabDhPZFFPTXd6dWk2Ny96bFFyUk90UXF4WXZ2?=
 =?utf-8?B?WVNaYzhUZzVPWDBzNlJ4dlNYbWVHWWt4M2ozeWtGNUNjeWdUKzJCOGNKNUhU?=
 =?utf-8?B?NWx6OW4yZlJLa2ZOcmZwcFZ3VU1uU0NEa1FZaHhUVzU2UFBZYk93WEdieU81?=
 =?utf-8?B?a01SRG9DTmY2WGNzQlY5OXUreGNraGZKSkYrOGo5bWFRcEtwMFFMV01PUE5H?=
 =?utf-8?B?WnRRN2pFZFl0Rk5oOWx3S3hrdWU0S2RodE9nSHZpeXFlS2xSWlE1dmZ4dWp5?=
 =?utf-8?B?L3MwWENxWms5VjNRTE14T3Vjem9JR1piQkhBU29ZRHRYRFFCQkFCT3U5VTZw?=
 =?utf-8?B?aHBaTGg4U21vTVVtWnh1dGF5eEl2K0FXdFVMNDc5Zm1OSUlGYVpUcDlWdEpG?=
 =?utf-8?B?WUNUaDdTMGJLZDlzeS9ybnIvMUM4LzNldW9zcmlGN3RiMHlWelExMjZRNjF3?=
 =?utf-8?B?N0tIZ2srR0dDSjNMbjQvQ1piK2I2eVN2UUl2dS9rS1JZMnh2elJGMjNTYmhL?=
 =?utf-8?B?QlV6K2ZzcVNUVGF4cDB1dWdMS1JBNFliQVV1TWxjUUlkNVd5SDRmMlZ6eWt2?=
 =?utf-8?B?TUJJam50VzdQcVhWRXFoTWo5eWM4RkQ5clMwaXZwem9lT3dEaXhSZ1hSUWxu?=
 =?utf-8?B?TE9oVjZDU0tjVm5JWkpMY1NRZThWUm82RlIvNmozQitoUTg2cjFGWWZqeW1C?=
 =?utf-8?B?MzVheDliU3lWNGFpQmN3V2NJcmlBVlRtUy9sTjJNVS8rSHFFZzlZT1c0cUV6?=
 =?utf-8?B?S0tTbkpqdytHcS9aRXBOUDlUYmtUVVZ1MmgrekZtMG0zZUtNVXBJRWhHUFBD?=
 =?utf-8?B?cFBqRzV5VmRxSk5wQ1RLY0NMY1VBSlROZk9VVmhRZHNiWmUyWElKRTZvem1B?=
 =?utf-8?B?Mlgzb1dGaStzZWcwT21jOWlwdjM3REtiOVBPMjRLL1FpQU8xL0FYQzIwN2pH?=
 =?utf-8?B?Rm5XQ0lvek8yMUJqRkZVYm81SHViVTdyVklBbUtPa2lXVTdJZVExaWtzNFYv?=
 =?utf-8?B?SisrL2NCYUFJZFI3RjN1OC9pMkdYQ1dxN21sNWpkdUJ5K1ZESmVLYi9PaGgw?=
 =?utf-8?B?UEVwYjd6S1hOcUd5ckxXVWpLOXRKRFduUTdjUDB1cGllRFZXWVhWMldOVUdL?=
 =?utf-8?B?ZDZyenVacmxVUFhlZ3liSzJGOFVJZjJ2RmZxT3pQU1JsZURJaU5KdnEzMTFB?=
 =?utf-8?B?UkJESlFva1ZyYytLRjErWVkwZmR6L2VGYURBY0lEanVURXpCTWljY1hqelk4?=
 =?utf-8?B?bUErcS9vMHhIdDFna3lXMTJ4clc5aFFCeHVNK3pId2JudC9wd0syMEtraExJ?=
 =?utf-8?B?OEFVSzlHek9DSnNEalpsNW9UNEhnVlA3d0IzcUVKNDZ0WnpnZTh3aHhVQmNx?=
 =?utf-8?B?YXA1RXZNblBuRk8waWI1UVBXand3UWVLaHFaZE1VSVVpR1Q0WWovMU5lNzhr?=
 =?utf-8?B?K0QyYit1RFg4dWNSbmRKUmpPYmhLNVBrNTVkZjY0VHJNTXdPcUZXbHpBZFZ1?=
 =?utf-8?B?eWxtWDZoaFNqWkdERXJZbzVSUmdjU1AvNVpPcktBamE2VHRvRkQ3Zk80VEU2?=
 =?utf-8?B?S1V3VS8vRzI3T0lyQ2hEeUszbDRGZ2dNNmNwd2pRZWxSVWQ0Um95aTJGdVox?=
 =?utf-8?B?eWNrcmhiRXlVWGJKNHprdWswWnBRc0pERGdnV0w1N3ZkVFJ5S2tGbFZxckxE?=
 =?utf-8?B?aHRLWGpCU1cwYUI5K2wwRkxwQUF6cG1raTJZQlYxOHU2SlhnSFJlYXBpeHlR?=
 =?utf-8?B?QlVtZFBEZk9zV1NIMHpRYUFscmlOQTQ0RmNMalNUQkU5NkY0b1hyNjdzbDZD?=
 =?utf-8?B?Y0xQM0EwNGtuTDhwSFpLQ1JnZ1FCRENsV21Dc3Y0QnZOWDZ6T1VBa2M3bDNV?=
 =?utf-8?B?OVo5ODhFaDlRNDczREtTbHFHQk9CYVFlMVBLOUlFUXZRWWNERjFzQlVkMk1I?=
 =?utf-8?B?b0NCbkxvUE9kMXBuakJzRlJFbzlVeURRcDQ4NDRSdGdycFA4YmdEMHdwUXMx?=
 =?utf-8?B?V0ZVQ0Y1K0lvZ0ZjRWVIRnc3b3ZURkZTeVR4N1dmWE5xREprNS9tNWlINGNk?=
 =?utf-8?Q?uNlKE5LISG+9fI7AMRnEfww=3D?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa0eff1-e8ab-4167-d236-08d9a5c4adec
X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB4108.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 10:10:40.6653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gs3L569+0VzcfetWi0Rp6HKZLhz+bSuUJwok/O0csiOMoBYGqZPkfOqYJwcVHGUSMXOEgNmUrrJefN8NEdI88w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR02MB4022
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2021/11/12 13:36, Gao Xiang 写道:
> Hi Jianan,
>
> On Fri, Nov 12, 2021 at 10:30:02AM +0800, Huang Jianan wrote:
>> Add sysfs interface to configure erofs related parameters later.
>>
>> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
>> Reviewed-by: Chao Yu <chao@kernel.org>
>> ---
>> since v4:
>> - Resend in a clean chain.
>>
>> since v3:
>> - Add description of sysfs in erofs documentation.
>>
>> since v2:
>> - Check whether t in erofs_attr_store is illegal.
>> - Print raw value for bool entry.
>>
>> since v1:
>> - Add sysfs API documentation.
>> - Use sysfs_emit over snprintf.
>>
>>   Documentation/ABI/testing/sysfs-fs-erofs |   7 +
>>   Documentation/filesystems/erofs.rst      |   8 +
>>   fs/erofs/Makefile                        |   2 +-
>>   fs/erofs/internal.h                      |  10 +
>>   fs/erofs/super.c                         |  12 ++
>>   fs/erofs/sysfs.c                         | 240 +++++++++++++++++++++++
>>   6 files changed, 278 insertions(+), 1 deletion(-)
>>   create mode 100644 Documentation/ABI/testing/sysfs-fs-erofs
>>   create mode 100644 fs/erofs/sysfs.c
>>
>> diff --git a/Documentation/ABI/testing/sysfs-fs-erofs b/Documentation/ABI/testing/sysfs-fs-erofs
>> new file mode 100644
>> index 000000000000..86d0d0234473
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-fs-erofs
>> @@ -0,0 +1,7 @@
>> +What:		/sys/fs/erofs/features/
>> +Date:		November 2021
>> +Contact:	"Huang Jianan" <huangjianan@oppo.com>
>> +Description:	Shows all enabled kernel features.
>> +		Supported features:
>> +		lz4_0padding, compr_cfgs, big_pcluster, device_table,
>> +		sb_chksum.
> Please help submit a patch renaming lz4_0padding to 0padding globally
> since LZMA and later algorithms also need that...
>
> Also, lack of chunked_file and compr_head2 as well?

It seems that these features are also missing in internal.h, I will send 
a new
patchset containing these fixes.

Thanks,
Jianan

> Thanks,
> Gao Xiang