Message-ID: <c6d3b7c2-4724-4dec-d29a-dee8f7e8cfc8@intel.com>
Date:   Fri, 12 Nov 2021 20:25:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [fs] a0918006f9: netperf.Throughput_tps -11.6% regression
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>,
        kernel test robot <oliver.sang@intel.com>
CC:     =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>,
        <lkp@lists.01.org>, <lkp@intel.com>, <ying.huang@intel.com>,
        <feng.tang@intel.com>, <zhengjun.xing@linux.intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Aleksa Sarai" <cyphar@cyphar.com>,
        Andy Lutomirski <luto@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Christian Heimes <christian@python.org>,
        Deven Bowers <deven.desai@linux.microsoft.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Eric Biggers <ebiggers@kernel.org>,
        Eric Chiang <ericchiang@google.com>,
        Florian Weimer <fweimer@redhat.com>,
        "Geert Uytterhoeven" <geert@linux-m68k.org>,
        James Morris <jmorris@namei.org>, "Jan Kara" <jack@suse.cz>,
        Jann Horn <jannh@google.com>, Jonathan Corbet <corbet@lwn.net>,
        Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        "Madhavan T . Venkataraman" <madvenka@linux.microsoft.com>,
        Matthew Garrett <mjg59@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        Miklos Szeredi <mszeredi@redhat.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        Paul Moore <paul@paul-moore.com>,
        =?UTF-8?Q?Philippe_Tr=c3=a9buchet?= 
        <philippe.trebuchet@ssi.gouv.fr>,
        Scott Shell <scottsh@microsoft.com>,
        "Shuah Khan" <shuah@kernel.org>,
        Steve Dower <steve.dower@python.org>,
        Steve Grubb <sgrubb@redhat.com>,
        Thibaut Sautereau <thibaut.sautereau@ssi.gouv.fr>,
        Vincent Strubel <vincent.strubel@ssi.gouv.fr>,
        <kernel-hardening@lists.openwall.com>, <linux-api@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-integrity@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@linux.microsoft.com>
References: <20211012192410.2356090-2-mic@digikod.net>
 <20211105064159.GB17949@xsang-OptiPlex-9020>
 <202111090920.4958E610D1@keescook>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <202111090920.4958E610D1@keescook>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzdWUXRvVDE2NHQwRFBwL2ZldEF0SG1FeXcyc0s2ME10V0VGNUlReUgzRS81?=
 =?utf-8?B?TURxQUNCa2s4b2FXUjdRaXZzTis5S01QQW04Z29oNk82ZGlFTFZhQ1ZoVklU?=
 =?utf-8?B?NXpVenpRMEd6S3BnSy9GS21kQ3VZTkN3TVF5OTBsakpEcjZMcUtUY2s2ZFM3?=
 =?utf-8?B?cDBFb1p3MGd1cU5yNTh0emFqWkFLR2NOZG50aHhBQUV3RmpzeWY5VzkwUG82?=
 =?utf-8?B?RnBuVTNhdmNIYWdVVGd0L0crUDMrRys0bTA1WFZ3NnBMa3hsa1hKNVk3NTZF?=
 =?utf-8?B?SDF6UnI2U3lnTkhqUldwL05Lb2tLTDVIa3h6WjR5SXVkVHFrYlJuSGpqWFBx?=
 =?utf-8?B?ZTRJMVpoQzBBTTJpVEhUOVEvZTJxaTNNNlhIOGFweWMyWk5nR3A3NTRIaFJ3?=
 =?utf-8?B?dTBiRCtDS3RLZ2lQSFdOZmI4a29vdVZ4UStidTdTOUU3SzJjdStscngwNmJY?=
 =?utf-8?B?OTJrcUtaOXpOS3VPL1E2REVhZGJNbDNGZEtkTDNvZE00dFh1anhzWmpya2NT?=
 =?utf-8?B?dkpxQjRJUDRSaXhPb1pSa2ZHNWVKc3MxQnoxd3Bsb214aTM5TlZiNnN6YmdQ?=
 =?utf-8?B?akZZU1lIMWptMUVlTXhHSk5PQVJYSlJYb1A0NWJQSE5pVW44K2RtcGx0SnB1?=
 =?utf-8?B?eTBMQm1DSnd2Q1pVV0NCMjNZQk1nK1N5VGdSU0J1alpCYVpCTGxWUkwrTGEz?=
 =?utf-8?B?WUxETm1NY3RzQkhtYjl1N2JKVEM3UTJyZ1ZvaE5RV0luU3BQMHIwYzNiOW03?=
 =?utf-8?B?aGZrUzk2VFh0V01MenJWM1JiWmRNdXVTWkdaTVVpaDRtcDdQY2tvSGFVN09G?=
 =?utf-8?B?bEdzUExYelBPNTZGMWxZNUFPWlpNczluNjJpYnRLMXYySkZKVFZiWjhvNmJn?=
 =?utf-8?B?dVBRUVU1cW81VUhEQVJYZkJ1dFFkVEljWFdlaWRsazRMOVVzSktxSHhVeCt5?=
 =?utf-8?B?b3NhNTQwUDFKZk05VXh6TFl1UnY3a25GVllRVVpNZDZXMllzRy9jdiswZFJ3?=
 =?utf-8?B?RXhCSXpBd2ZQREsvRUxtVHlVRS9XVUtxclNqY29WcmhPU00vbHRjbTNjTGZn?=
 =?utf-8?B?c3VGdDVFMlBHWXUzTy9ZZm9SbVJVc3JqaUN1NVc5RGRlZmE5OUUzTTU2TWpN?=
 =?utf-8?B?RitCY2VQSnA5aU90a2pFQ1N1eXpxR0UzVU1PamJTLzk3N0VtZ3RobzRBZzIx?=
 =?utf-8?B?YUVQSXFMWUVhRm1FWTlTb3F3aG1JNDd2bzlEbEFJd0c5SjVXKzJXRmltNk9N?=
 =?utf-8?B?ZkNtRmxjaHdTd0s3VG1lbUJkYUIrdmZZQW1KMENMVVlneHNUemdJZzB1R2ZR?=
 =?utf-8?B?a2V1dCtwNCtWYkZKOEFuSU8zbVdSZ3pxYnVwV3gyWEY1YTFpRGFNWXlvVSt1?=
 =?utf-8?B?TDk3UXFqM25BNm9vcFlBcjNGb2pJUnoxeGYwdFV0aWpIQkQxTldndjdrYmJ5?=
 =?utf-8?B?UytDSHl2VWxMQXl1aDh2V1VGNCtoTEM2NjRkODU0dkxvb1BHZHBoUkRteTNq?=
 =?utf-8?B?QldYSHVZWWRSd1RuVHpLaTQ4bEM4MmRXNXpsNzFwQ3pwUnYveGtNdjF4bzNI?=
 =?utf-8?B?ZFhkZGhzR2N6UmlFQnQyaUVJa3FKTWd2V2JJcU8yam8wSHgvN1FXSkV3NGtQ?=
 =?utf-8?B?VU9LanJNaERwVjFNTkVyL3NOcTdtejdzbElhd1djQkZLM3JRc0tiWi9UVnBl?=
 =?utf-8?B?dmVya3hDRTBpaXdkb1FkZG50eFV4YzRKby9aMDRlU3ROdVJwWkNXTmIyN1k2?=
 =?utf-8?B?YlZxcEl4MUlHaGIvcnZTeHZnWnZ6eTgzOXBkcjY5Zll0NFJiZXFGaExGRWRX?=
 =?utf-8?B?WS8wbmI0MlpqblFCRW54aWYyWFBPVFNYc2xXN053SzloNkc1c0JCRkx1ZWtO?=
 =?utf-8?B?UlNhTWc3QTMvYTAyczRiUmZzZGJCMFgzcVMvcFZVaEk0TWFhZXRnOGlTdEJa?=
 =?utf-8?B?SHoveFh3NUlVNjBxWktLenJHTTBMTU1ndUVDcmVNQ09TSzVIV0U3UTZlZ2I5?=
 =?utf-8?B?RmhucHZTMCt5cTJOajdqQ1hCS1hXMGpPci9yNXZSaTUrNW5nRmZrNU1oRHFk?=
 =?utf-8?B?YkduTnJJd01OVlNQUml3dVowSGRQWDJaT0pVM1VKa09OVVV4a1h3emc0RXZz?=
 =?utf-8?B?a3JaVjJhUmlpRWpBckdEQ2tNVjRHRitZNEpzNnhhUEVOMHpPNzNOWUN5NEhJ?=
 =?utf-8?Q?CwJVE8nEZ/uj2w17smV9wv4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f72abbe-a3f0-47b0-bf6e-08d9a5d78323
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 12:25:29.0198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WGIV8pMPuPHcPHQeJeyF0bZqhglauUH++CGIF9DEAVPxWCMpXdSVCqwZ+RJphK+hA3oTU+0Pj6UShIngejYmlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1357
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kees,

On 11/10/2021 1:21 AM, Kees Cook wrote:
>> I suppose these three CPUs have different cache policy. It also could be
>> related with netperf throughput testing.
> Does moving the syscall implementation somewhere else change things?
I moved the syscall implementation to a stand alone file and put the file
to net directory for testing. The new patch is like:
https://zerobin.net/?a2b782afadf3c428#Me8l4AJuhiSCfaLVWVzydAVIK6ves0EVIVD76wLnVQo=


The test result is like following:
     - on Cascade Lake: -10.4%
    356365           -10.4%     319180        netperf.Throughput_total_tps
     22272           -10.4%      19948        netperf.Throughput_tps


     - on Cooper Lake: -4.0%
    345772 ±  4%      -4.0%     331814        netperf.Throughput_total_tps
     21610 ±  4%      -4.0%      20738        netperf.Throughput_tps


     - on Ice Lake: -1.1%
    509824            -1.1%     504434        netperf.Throughput_total_tps
     31864            -1.1%      31527        netperf.Throughput_tps


Regards
Yin, Fengwei