Date:   Fri, 12 Nov 2021 13:46:38 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: regulator: Add bindings for Unisoc's
 SC2730 regulator
Message-ID: <YY5wPh0rwRvFjSRG@sirena.org.uk>
References: <20211008031953.339461-1-zhang.lyra@gmail.com>
 <20211008031953.339461-3-zhang.lyra@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BXpsF9fcILSz6uPG"
Content-Disposition: inline
In-Reply-To: <20211008031953.339461-3-zhang.lyra@gmail.com>
Precedence: bulk


--BXpsF9fcILSz6uPG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 08, 2021 at 11:19:53AM +0800, Chunyan Zhang wrote:

> +properties:
> +  compatible:
> +    const: sprd,sc2730-regulator

I still don't understand why this MFD subfunction for a specific device
is a separate binding with a separate compatible string, the issues I
mentioned previously with this just encoding current Linux internals
into the DT rather than describing the device still apply.

--BXpsF9fcILSz6uPG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGOcD4ACgkQJNaLcl1U
h9DNPwf9FzYXDmsgF2KZJNeBv/iF2rCDy8hHO87Dv4BvJmDmiCLBQ1JwutQIzVPq
jQrjyg7VvKqQ5ETgH8nwqQqCzkPjG/hdNSZPRQmSiUVwx+ZhuiiwUPr/gObaV161
812O3TL8HdEI46C1tKEteoDhze5w3Oxy/jCTcQfjkSO5BA+V7DYu55ZzXVkWgCBD
8xQv9nKDyr0cY0ZoO6iJkm0tiHTZuTSHCICdizBXyg1FhPwTI9XrpJZQvePg6okD
q7ztUS//QZz+vMG65Sz7E0l8cfbpOR6hgLP/PVpLXgF1nXdBsQinPdU0IfQp73Nh
yVh3RTySxjb9b+GdTbEZ5n6RQ5v5Ow==
=NMca
-----END PGP SIGNATURE-----

--BXpsF9fcILSz6uPG--