Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH V4 6/9] dt-bindings: watchdog: imx7ulp-wdt: Add imx8ulp
 compatible string
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, robh+dt@kernel.org,
        aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
        ulf.hansson@linaro.org, broonie@kernel.org, wim@linux-watchdog.org,
        linux@rempel-privat.de
Cc:     kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
        linux-serial@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Jacky Bai <ping.bai@nxp.com>,
        Rob Herring <robh@kernel.org>, Peng Fan <peng.fan@nxp.com>
References: <20211112082930.3809351-1-peng.fan@oss.nxp.com>
 <20211112082930.3809351-7-peng.fan@oss.nxp.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <ecd1b962-0401-e077-f1c4-426fafde58f8@roeck-us.net>
Date:   Fri, 12 Nov 2021 06:28:08 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211112082930.3809351-7-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/12/21 12:29 AM, Peng Fan (OSS) wrote:
> From: Jacky Bai <ping.bai@nxp.com>
> 
> The wdog on i.MX8ULP is derived from i.MX7ULP, it uses two compatible
> strings, so update the compatible string for i.MX8ULP.
> 
> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
>   - v4 changes:
>     no
> 
>   - v3 changes:
>     no
> 
>   - v2 changes:
>     refine the commit message
> 
>   .../devicetree/bindings/watchdog/fsl-imx7ulp-wdt.yaml      | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.yaml
> index 51d6d482bbc2..fb603a20e396 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx7ulp-wdt.yaml
> @@ -14,8 +14,11 @@ allOf:
>   
>   properties:
>     compatible:
> -    enum:
> -      - fsl,imx7ulp-wdt
> +    oneOf:
> +      - const: fsl,imx7ulp-wdt
> +      - items:
> +          - const: fsl,imx8ulp-wdt
> +          - const: fsl,imx7ulp-wdt
>   
>     reg:
>       maxItems: 1
>