Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750897AbXAIB27 (ORCPT ); Mon, 8 Jan 2007 20:28:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750898AbXAIB27 (ORCPT ); Mon, 8 Jan 2007 20:28:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:43628 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbXAIB25 (ORCPT ); Mon, 8 Jan 2007 20:28:57 -0500 Date: Tue, 9 Jan 2007 02:28:54 +0100 From: Kurt Garloff To: Linux kernel list , Linux SCSI list Subject: [PATCH] scsi_scan message cosmetic error Message-ID: <20070109012854.GV18689@tpkurt.garloff.de> Mail-Followup-To: Kurt Garloff , Linux kernel list , Linux SCSI list Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wiiWofWi8Et/oezL" Content-Disposition: inline X-Operating-System: Linux 2.6.16.21-0.25-default i686 X-PGP-Info: on http://www.garloff.de/kurt/mykeys.pgp X-PGP-Key: 1024D/1C98774E Organization: SUSE/Novell User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2309 Lines: 68 --wiiWofWi8Et/oezL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Minor typo ...=20 In my first iteration of patches (that got merged), the BLIST_ATTACH_PQ3 actually had the value 0x800000, but that got changed later to avoid conflicts. This piece must have been overlooked. You could obviously do something like %x and then add the bitflags, but that looks overkill for something that does not tend to change. Please merge. (Patch applied against latest 2.6.20rc version that I tested.) =46rom: Kurt Garloff Subject: [SCSI SCAN] Fix logging message for PQ3 devices The blacklist flags BLIST_ATTACH_PQ3 has value 0x1000000, not 0x800000. Signed-off-by: Kurt Garloff Index: linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-2.6.16-SLES10_SP1_BRANCH.orig/drivers/scsi/scsi_scan.c +++ linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c @@ -941,9 +941,9 @@ static int scsi_probe_and_add_lun(struct unsigned char mod[17]; =20 sdev_printk(KERN_INFO, sdev, "scsi scan: consider passing scsi_mod." - "dev_flags=3D%s:%s:0x240 or 0x800240\n", + "dev_flags=3D%s:%s:0x240 or 0x1000240\n", scsi_inq_str(vend, result, 8, 16), scsi_inq_str(mod, result, 16, 32)); }); } --=20 Kurt Garloff [Koeln, DE] Physics:Plasma modeling [TU Eindhoven, NL] Linux: Head Architect [Novell Inc] --wiiWofWi8Et/oezL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFou/WxmLh6hyYd04RAkFyAJ4mj7urdLMTdnKy/RM2jGmUhmmEiwCgpJEM T64BmEAaiE6RtUKmWlJwbj0= =it/J -----END PGP SIGNATURE----- --wiiWofWi8Et/oezL-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/