Date:   Fri, 12 Nov 2021 09:44:31 -0600
From:   Rob Herring <robh@kernel.org>
To:     "LH.Kuo" <lhjeff911@gmail.com>
Cc:     rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
        rui.zhang@intel.com, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        qinjian@cqplus1.com, wells.lu@sunplus.com,
        "LH.Kuo" <lh.kuo@sunplus.com>
Subject: Re: [PATCH 2/2] devicetree bindings THERMAL Add bindings doc for
 Sunplus SP7021
Message-ID: <YY6L307obyk2XMx3@robh.at.kernel.org>
References: <1635756310-25415-1-git-send-email-lh.kuo@sunplus.com>
 <1635756310-25415-3-git-send-email-lh.kuo@sunplus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1635756310-25415-3-git-send-email-lh.kuo@sunplus.com>
Precedence: bulk

On Mon, Nov 01, 2021 at 04:45:10PM +0800, LH.Kuo wrote:
> Add devicetree bindings THERMAL Add bindings doc for Sunplus SP7021

Not a complete sentence.

Write subject lines matching 'git log --oneline' of the 
directory/subsystem your change is in.

> 
> Signed-off-by: LH.Kuo <lh.kuo@sunplus.com>
> ---
>  .../bindings/thermal/sunplus_thermal.yaml          | 52 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> new file mode 100644
> index 0000000..1875d04
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sunplus_thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus Thermal controller
> +
> +maintainers:
> +  - lh.kuo <lh.kuo@sunplus.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sunplus,sp7021-thermal
> +
> +  reg:
> +    items:
> +      - description: Base address and length of the Thermal registers
> +      - description: Base address and length of the Thermal calibration registers
> +
> +  reg-names:
> +    items:
> +      - const: thermal_reg
> +      - const: thermal_moon4

thermal_ is redundant.

> +
> +  nvmem-cells:
> +    maxItems: 1
> +
> +  nvmem-cell-names:
> +    const: therm_calib
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - nvmem-cells
> +  - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    thermal: serial@9c000280 {

Drop unused labels.

> +        compatible = "sunplus,sp7021-thermal";
> +        reg = <0x9c000280 0x80>, <0x9c000200 0x80>;
> +        reg-names = "thermal_reg", "thermal_moon4";
> +        nvmem-cells = <&therm_calib>;
> +        nvmem-cell-names = "therm_calib";
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dff822b..2080b00 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17949,6 +17949,7 @@ SUNPLUS THERMAL DRIVER
>  M:	LH Kuo <lh.kuo@sunplus.com>
>  L:	linux-pm@vger.kernel.org
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
>  F:	drivers/thermal/sunplus_thermal.c
>  
>  SUPERH
> -- 
> 2.7.4
> 
>