Date:   Fri, 12 Nov 2021 16:20:13 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Cai Huoqing <caihuoqing@baidu.com>, linux-iio@vger.kernel.org,
        kernel-janitors@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended
 ARCH_MXC config
Message-ID: <20211112162013.01f4f171@jic23-huawei>
In-Reply-To: <CAOMZO5B4k=UvE5XTgbsjCfoo0h0Y7H+xN6mwh9Bnc2L82QYzwQ@mail.gmail.com>
References: <20211111083954.6286-1-lukas.bulwahn@gmail.com>
        <CAOMZO5B4k=UvE5XTgbsjCfoo0h0Y7H+xN6mwh9Bnc2L82QYzwQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 11 Nov 2021 07:31:25 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Hi Lukas,
> 
> On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> > the non-existing config ARCH_MXC_ARM64.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns:
> >
> >   ARCH_MXC_ARM64
> >   Referencing files: drivers/iio/adc/Kconfig
> >
> > Probably, the existing config ARCH_MXC is intended to be referred here.
> > So, repair the dependency to refer to that config.
> >
> > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>  
> 
> This looks good.
> 
> The incorrect  ARCH_MXC_ARM64 symbol probably came when porting the
> driver from the NXP downstream kernel:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan