Date:   Fri, 12 Nov 2021 09:37:31 -0700
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Jinlong <quic_jinlmao@quicinc.com>
Cc:     Tao Zhang <quic_taozha@quicinc.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Trilok Soni <quic_tsoni@quicinc.com>
Subject: Re: [PATCH 05/10] Coresight: Add interface for TPDM BC subunit
Message-ID: <20211112163731.GA2162006@p14s>
References: <1634801936-15080-1-git-send-email-quic_taozha@quicinc.com>
 <1634801936-15080-6-git-send-email-quic_taozha@quicinc.com>
 <20211104180106.GD491267@p14s>
 <20211105082625.GE25738@jinlmao-gv.ap.qualcomm.com>
 <20211112084228.GA24524@jinlmao-gv.ap.qualcomm.com>
 <20211112091034.GA28079@jinlmao-gv.ap.qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211112091034.GA28079@jinlmao-gv.ap.qualcomm.com>
Precedence: bulk

On Fri, Nov 12, 2021 at 05:10:38PM +0800, Jinlong wrote:
> On Fri, Nov 12, 2021 at 04:42:31PM +0800, Jinlong wrote:
> > [....]
> > 
> > > >  	&tpdm_attr_grp,
> > > > > +	&tpdm_bc_attr_grp,
> > > > 
> > > > It is quite tedious to review all these options at the same time as the core
> > > > drivers.  I suggest to concentrate on the base functionality for now.  When that
> > > > is merged we can add configuration options such as these.
> > > > 
> > > > I am out of time for this patchset and as such will not review the remaining
> > > > patches - those will have to wait for another iteration.
> > > > 
> > > > Thanks,
> > > > Mathieu
> > > 
> > > 
> > > Thank your for all the comments.
> > > We will update the patches.
> > > 
> > > Thanks
> > > Jinlong Mao 
> > > 
> >
> 
> Correct the typo.
> 
>  Hi Mathieu,
>  
>  We will reduce the code changes.
>  There will be code changes below for next version:
>  
>  1. coresight: add support to enable more coresight paths
>  2. Basic function for TPDM(only enable/disable functions)
>  3. TPDA driver
>  
>  Is that ok for you ?

Yes, that sounds much better.

Regards,
Mathieu

> > 
> > > > 
> > > > >  	NULL,
> > > > >  };
> > > > >  
> > > > > -- 
> > > > > 2.17.1
> > > > >