MIME-Version: 1.0
References: <20211112151602.1378857-1-sashal@kernel.org>
In-Reply-To: <20211112151602.1378857-1-sashal@kernel.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Fri, 12 Nov 2021 11:16:14 -0800
Message-ID: <CAHk-=wiAWDZRzzG8T7fiBBESM9S-Uzy7OFVY9iv-UwjpAbhp-Q@mail.gmail.com>
Subject: Re: [PATCH] tools/lib/lockdep: drop liblockdep
To:     Sasha Levin <sashal@kernel.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 12, 2021 at 7:16 AM Sasha Levin <sashal@kernel.org> wrote:
>
> TL;DR: While a tool like liblockdep is useful, it probably doesn't
> belong within the kernel tree.

I have eagerly applied this patch, because I wasn't too happy with
that thing in the first place.

However - I do note that there's signs of liblockdep in the
tools/include/ directory still.

Some of those headers may now be dead, and should be removed, but I
didn't end up trying to figure it out, so I left them alone.

This stupid shell command

    git grep -il liblockdep tools/include/ |
        sed 's:tools/include/::' |
        while read i; do echo; echo $i:; echo; git grep $i tools/ ; done

seems to say that yes, the <linux/module.h> header in the tools
directory is still used, but the rest of them seem to only reference
other dead headers.

Hmm? It would be lovely to clean those headers up too and get rid of
them - because those headers are very much part of why I hated the
whole liblockdep mess, and why I was so happy to immediately apply
this patch..

              Linus