Message-ID: <ee12204f-0bfb-5b64-ef77-9217eb7dc456@gmail.com>
Date:   Fri, 12 Nov 2021 22:01:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: netdevice.7 SIOCGIFFLAGS/SIOCSIFFLAGS
Content-Language: en-US
To:     Erik Flodin <erik@flodin.me>
Cc:     mtk.manpages@gmail.com, linux-man@vger.kernel.org,
        Stefan Rompf <stefan@loplof.de>,
        "David S. Miller" <davem@davemloft.net>,
        John Dykstra <john.dykstra1@gmail.com>, netdev@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <CAAMKmof+Y+qrro7Ohd9FSw1bf+-tLMPzaTba-tVniAMY0zwTOQ@mail.gmail.com>
 <b0a534b3-9bdf-868e-1f28-8e32d31013a2@gmail.com>
 <CAAMKmodhSsckMxH9jLKKwXN_B76RoLmDttbq5X9apE-eCo0hag@mail.gmail.com>
 <1cde5a72-033e-05e7-be58-b1b2ef95c80f@gmail.com>
 <CAAMKmoe8rUuoxFK2gKZL4um79gmtn-__-1ZDWuBgGTqfqPjZdw@mail.gmail.com>
 <ec0d0a2d-235c-a71f-92bc-45e1156bff9e@gmail.com>
 <CAAMKmocBEr05EfidF9CfqJQw4uj1YcYwmkJPR=c0eCCYgsAHwg@mail.gmail.com>
From:   "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
In-Reply-To: <CAAMKmocBEr05EfidF9CfqJQw4uj1YcYwmkJPR=c0eCCYgsAHwg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Erik,

On 10/2/21 18:35, Erik Flodin wrote:
> A bit more than a month has passed so here's a ping :)
> 
> // Erik

Thanks for the ping.

alarm(3600 * 24 * 30);  // :)

> 
> On Fri, 30 Apr 2021 at 21:32, Alejandro Colomar (man-pages) 
> <alx.manpages@gmail.com <mailto:alx.manpages@gmail.com>> wrote:
> 
>     [PING mtk, netdev@]
>     [CC += linux-kernel]
> 
>     Hi Erik,
> 
>     On 4/29/21 9:45 PM, Erik Flodin wrote:
>      > On Wed, 14 Apr 2021 at 21:56, Alejandro Colomar (man-pages)
>      > <alx.manpages@gmail.com <mailto:alx.manpages@gmail.com>> wrote:
>      >>
>      >> [CC += netdev]
>      >>
>      >> Hi Erik,
>      >>
>      >> On 4/14/21 8:52 PM, Erik Flodin wrote:
>      >>> Hi,
>      >>>
>      >>> On Fri, 19 Mar 2021 at 20:53, Alejandro Colomar (man-pages)
>      >>> <alx.manpages@gmail.com <mailto:alx.manpages@gmail.com>> wrote:
>      >>>> On 3/17/21 3:12 PM, Erik Flodin wrote:
>      >>>>> The documentation for SIOCGIFFLAGS/SIOCSIFFLAGS in
>     netdevice.7 lists
>      >>>>> IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO, but those can't be set in
>      >>>>> ifr_flags as it is only a short and the flags start at 1<<16.
>      >>>>>
>      >>>>> See also
>     https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=746e6ad23cd6fec2edce056e014a0eabeffa838c
>     <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=746e6ad23cd6fec2edce056e014a0eabeffa838c>
>      >>>>>
>      >>>>
>      >>>> I don't know what's the history of that.
>      >>>
>      >>> Judging from commit message in the commit linked above it was
>     added by
>      >>> mistake. As noted the flags are accessible via netlink, just
>     not via
>      >>> SIOCGIFFLAGS.
>      >>>
>      >>> // Erik
>      >>>
>      >>
>      >> I should have CCd netdev@ before.  Thanks for the update.  Let's
>     see if
>      >> anyone there can comment.
>      >>
>      >> Thanks,
>      >>
>      >> Alex
>      >>
> 
>      > Hi again,
>      >
>      > Have there been any updates on this one?
> 
>     No, Noone from the kernel answered.  And I'm sorry, but I'm not sure
>     what is going on in the code, so I don't want to close this here by just
>     removing those flags from the manual page, because I worry that the
>     actual code may be wrong or something.  So I prefer that when Michael
>     has some time he can maybe review this and say something.  Ideally,
>     someone from the kernel would also respond, but they haven't.  I've CCd
>     the LKML; let's see if someone reads this and can help.
> 
>     Thanks,
> 
>     Alex
> 
>     P.S.:  Please, if we haven't responded in a month from now, ping us
>     again.  Thanks again.
> 
>      >
>      > // Erik
>      >
>      >>
>      >> --
>      >> Alejandro Colomar
>      >> Linux man-pages comaintainer;
>     https://www.kernel.org/doc/man-pages/
>     <https://www.kernel.org/doc/man-pages/>
>      >> http://www.alejandro-colomar.es/ <http://www.alejandro-colomar.es/>
> 
>     -- 
>     Alejandro Colomar
>     Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
>     <https://www.kernel.org/doc/man-pages/>
>     http://www.alejandro-colomar.es/ <http://www.alejandro-colomar.es/>
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/