Message-ID: <2dcf1dcf98216096c52cbd69553ce71edf62a3c5.camel@HansenPartnership.com>
Subject: Re: [GIT PULL] final round of SCSI updates for the 5.15+ merge
 window
From:   James Bottomley <James.Bottomley@HansenPartnership.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Fri, 12 Nov 2021 17:03:14 -0500
In-Reply-To: <CAHk-=wgJz2-KgygzF6s4D80=ib0AmP99TGd3Wgc_GqyKg1=pHA@mail.gmail.com>
References: <d9405d786496756564b31540cc73a9d22cc97730.camel@HansenPartnership.com>
         <CAHk-=wgJz2-KgygzF6s4D80=ib0AmP99TGd3Wgc_GqyKg1=pHA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-11-12 at 12:34 -0800, Linus Torvalds wrote:
> On Fri, Nov 12, 2021 at 5:43 AM James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > This series is all the stragglers that didn't quite make the first
> > merge window pull.  It's mostly minor updates and bug fixes of
> > merge window code but it also has two driver updates: ufs and
> > qla2xxx.
> 
> Hmm? No diffstat?
> 
> I suspect it's because there's a merge in there, and thus multiple
> merge base commits, and the autogenerated diffstat ends up being
> worthless.

Um, no, it's because I forgot, sorry.

> In that situation, the nice thing to do is to at least tell me why
> there's no diffstat, but optimally you can do a temporary throw-away
> merge in a temporary branch just to get the diffstat.
> 
> And yes, "git request-pull" could do that, automating this all and
> reporting any conflicts at the same time.
> 
> But git historically did *not* do that just because it requires a
> working tree and can be messy, and because the "just do the diff from
> the merge base" works fine for maintainers that don't do merges
> themselves, and so the only maintainers that can hit this issue are
> the maintainers that also should be able to do that temporary merge
> thing on their own.
> 
> Anyway, I don't require that temporary merge, but I _do_ really want
> to get notified of "look, I did the diffstat, and it was useless
> garbage, so I'm not including it here".
> 
> Because as-is, this just looks like an incomplete pull request.
> 
> I've done the pull, verified the shortlog, and checked that the
> (proper) diffstat all looks sane. But I am writing this email just to
> say "you could have done so much better".

Will do next time, sorry.

James