MIME-Version: 1.0
References: <20211112061651.6509-1-ye.guojin@zte.com.cn>
In-Reply-To: <20211112061651.6509-1-ye.guojin@zte.com.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 12 Nov 2021 17:58:12 -0500
Message-ID: <CADnq5_PbjTWCgY-WrNdYna+Dr6F0+OiMEcjk5FpEk9VUSM9U-g@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: fix cond_no_effect.cocci warnings
To:     CGEL <cgel.zte@gmail.com>
Cc:     "Wentland, Harry" <harry.wentland@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        "Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Zeal Robot <zealci@zte.com.cn>,
        xinhui pan <Xinhui.Pan@amd.com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
        Dave Airlie <airlied@linux.ie>, Jerry Zuo <Jerry.Zuo@amd.com>,
        Vladimir Stempen <vladimir.stempen@amd.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Ye Guojin <ye.guojin@zte.com.cn>, Jun Lei <Jun.Lei@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        Jimmy Kizito <Jimmy.Kizito@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Nov 12, 2021 at 1:17 AM <cgel.zte@gmail.com> wrote:
>
> From: Ye Guojin <ye.guojin@zte.com.cn>
>
> This was found by coccicheck:
> ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c, 2516, 7-9, WARNING
> possible condition with no effect (if == else)
>
> hdmi_info.bits.YQ0_YQ1 is always YYC_QUANTIZATION_LIMITED_RANGE.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> index fabe1b83bd4f..564163a85d2c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> @@ -2509,17 +2509,7 @@ static void set_avi_info_frame(
>
>         /* TODO : We should handle YCC quantization */
>         /* but we do not have matrix calculation */
> -       if (stream->qy_bit == 1) {
> -               if (color_space == COLOR_SPACE_SRGB ||
> -                       color_space == COLOR_SPACE_2020_RGB_FULLRANGE)
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -               else if (color_space == COLOR_SPACE_SRGB_LIMITED ||
> -                                       color_space == COLOR_SPACE_2020_RGB_LIMITEDRANGE)
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -               else
> -                       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> -       } else
> -               hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
> +       hdmi_info.bits.YQ0_YQ1 = YYC_QUANTIZATION_LIMITED_RANGE;
>
>         ///VIC
>         format = stream->timing.timing_3d_format;
> --
> 2.25.1
>