MIME-Version: 1.0
References: <20211111154930.3603189-1-pbonzini@redhat.com>
In-Reply-To: <20211111154930.3603189-1-pbonzini@redhat.com>
From:   Peter Gonda <pgonda@google.com>
Date:   Fri, 12 Nov 2021 16:12:06 -0700
Message-ID: <CAMkAt6qtNcOSP93SYsj_s4EfbyV9L5K0aHgTBT+PJ5uJ-zjM1g@mail.gmail.com>
Subject: Re: [PATCH v12 0/7] Add AMD SEV and SEV-ES intra host migration support
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        seanjc@google.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 11, 2021 at 8:49 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> This is a fixed version of Peter Gonda's series.  The main change is
> that it uses the "bugged" VM implementation (now renamed to "dead")
> to ensure the source VM is inoperational, and that it correctly
> charges the current cgroup for the ASID.
>
> I also renamed the capability to KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM,
> since it is similar to KVM_CAP_VM_COPY_ENC_CONTEXT_FROM.
>
> Paolo Bonzini (2):
>   KVM: generalize "bugged" VM to "dead" VM
>   KVM: SEV: provide helpers to charge/uncharge misc_cg

Thanks for these Paolo! I took a quick look through these. I can send
some additional testing for the new "dead" VM functionality on the
source side VM and I'll try to test when the cgroup is maxed out we
can still do an intra-host migration (make sure we aren't charging
double during the migration) in a follow up patch. I guess the cgroup
stuff in general could use some testing.

Also thanks for the detailed reviews Sean.

>
> Peter Gonda (5):
>   KVM: SEV: Refactor out sev_es_state struct
>   KVM: SEV: Add support for SEV intra host migration
>   KVM: SEV: Add support for SEV-ES intra host migration
>   selftest: KVM: Add open sev dev helper
>   selftest: KVM: Add intra host migration tests
>
>  Documentation/virt/kvm/api.rst                |  15 +
>  arch/x86/include/asm/kvm_host.h               |   1 +
>  arch/x86/kvm/svm/sev.c                        | 303 +++++++++++++++---
>  arch/x86/kvm/svm/svm.c                        |   9 +-
>  arch/x86/kvm/svm/svm.h                        |  28 +-
>  arch/x86/kvm/x86.c                            |   8 +-
>  include/linux/kvm_host.h                      |  12 +-
>  include/uapi/linux/kvm.h                      |   1 +
>  tools/testing/selftests/kvm/Makefile          |   3 +-
>  .../testing/selftests/kvm/include/kvm_util.h  |   1 +
>  .../selftests/kvm/include/x86_64/svm_util.h   |   2 +
>  tools/testing/selftests/kvm/lib/kvm_util.c    |  24 +-
>  tools/testing/selftests/kvm/lib/x86_64/svm.c  |  13 +
>  .../selftests/kvm/x86_64/sev_migrate_tests.c  | 203 ++++++++++++
>  virt/kvm/kvm_main.c                           |  10 +-
>  15 files changed, 551 insertions(+), 82 deletions(-)
>  create mode 100644 tools/testing/selftests/kvm/x86_64/sev_migrate_tests.c
>
> --
> 2.27.0
>