From:   Stefan Schaeckeler <schaecsn@gmx.net>
To:     richard@nod.at
CC:     linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        sschaeck@cisco.com
In-reply-to: <2065858791.38760.1635277003599.JavaMail.zimbra@nod.at> (message
        from Richard Weinberger on Tue, 26 Oct 2021 21:36:43 +0200 (CEST))
Subject: Re: [PATCH v2] ubifs: ubifs to export filesystem error counters
Content-Type: text/plain
Reply-to: schaecsn@gmx.net
References: <20211010042239.2888-1-schaecsn@gmx.net> <2065858791.38760.1635277003599.JavaMail.zimbra@nod.at>
Message-Id: <20211113021330.3CA4527F135@corona.crabdance.com>
Date:   Fri, 12 Nov 2021 18:13:30 -0800 (PST)
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Richard,

> > Not all ubifs filesystem errors are propagated to userspace.
> >
> > Export bad magic, bad node and crc errors via sysfs. This allows users=
pace
> > to notice filesystem errors:
> >
> > /sys/fs/ubifs/ubiX_Y/errors_magic
> > /sys/fs/ubifs/ubiX_Y/errors_node
> > /sys/fs/ubifs/ubiX_Y/errors_crc
> >
> > The counters are reset to 0 with a remount.
> >
> > Signed-off-by: Stefan Schaeckeler <sschaeck@cisco.com>
> > ---
> > Changes in v2:
> >  - merged sysfs.h header into ubifs.h.
> >  - io.c: wrapped incrementing error counters into new functions
> >    record_*_error().
> >  - sysfs.c: removed sysfs write callback for clearing stats.
> >  - sysfs.c: ubifs_sysfs_register(): free c->stats on error.
> >  - sysfs.c: ubifs_attr_show(): use sysfs_emit().
> >
> > fs/ubifs/Makefile |   2 +-
> > fs/ubifs/io.c     |  21 +++++++
> > fs/ubifs/super.c  |  16 ++++-
> > fs/ubifs/sysfs.c  | 153 ++++++++++++++++++++++++++++++++++++++++++++++
> > fs/ubifs/ubifs.h  |  35 +++++++++++
> > 5 files changed, 225 insertions(+), 2 deletions(-)
> > create mode 100644 fs/ubifs/sysfs.c
>
> Queued for 5.16.

The merge window for 5.16 is about to close. May I point out that, as far =
as I
can tell, you have not sent a pull request for ubifs, yet.

 Stefan