MIME-Version: 1.0
References: <20211110111750.27263-1-alexandru.tachici@analog.com>
 <20211110111750.27263-4-alexandru.tachici@analog.com> <20211112171448.79b4e8cc@jic23-huawei>
In-Reply-To: <20211112171448.79b4e8cc@jic23-huawei>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 13 Nov 2021 19:00:11 +0200
Message-ID: <CAHp75Vf8+HH8t-pqXtd3=FT5=9T4T2ke+ceQ-pyAyvmH2pN9zQ@mail.gmail.com>
Subject: Re: [PATCH 3/5] iio: adc: ad_sigma_delta: Add sequencer support
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Alexandru Tachici <alexandru.tachici@analog.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 12, 2021 at 7:10 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Wed, 10 Nov 2021 13:17:48 +0200
> <alexandru.tachici@analog.com> wrote:


> > +     kfree(sigma_delta->samples_buf);
>
> krealloc() preferred.   It might not be necessary to actually do an allocation after all
> if we happen to have one we can already use.

Looking at below, shouldn't it be krealloc_array()?

> > +     sigma_delta->samples_buf = kzalloc(slot * indio_dev->channels[0].scan_type.storagebits,
> > +                                        GFP_KERNEL);


-- 
With Best Regards,
Andy Shevchenko