Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbXAIHRI (ORCPT ); Tue, 9 Jan 2007 02:17:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751129AbXAIHRH (ORCPT ); Tue, 9 Jan 2007 02:17:07 -0500 Received: from outmx027.isp.belgacom.be ([195.238.4.208]:38730 "EHLO outmx027.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbXAIHRG (ORCPT ); Tue, 9 Jan 2007 02:17:06 -0500 Message-ID: <45A340E4.5030702@246tNt.com> Date: Tue, 09 Jan 2007 08:14:44 +0100 From: Sylvain Munaut User-Agent: Thunderbird 1.5.0.4 (X11/20060615) MIME-Version: 1.0 To: Benjamin Herrenschmidt CC: Greg KH , Mariusz Kozlowski , linuxppc-dev@ozlabs.org, Linus Torvalds , paulus@samba.org, Linux Kernel Mailing List Subject: Re: Linux 2.6.20-rc4 References: <200701081550.27748.m.kozlowski@tuxland.pl> <45A25C17.5070606@246tNt.com> <1168303139.22458.246.camel@localhost.localdomain> <20070109005624.GA598@suse.de> <1168308323.22458.254.camel@localhost.localdomain> In-Reply-To: <1168308323.22458.254.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2507 Lines: 68 Benjamin Herrenschmidt wrote: > On Mon, 2007-01-08 at 16:56 -0800, Greg KH wrote: >> On Tue, Jan 09, 2007 at 11:38:59AM +1100, Benjamin Herrenschmidt wrote: >>> On Mon, 2007-01-08 at 15:58 +0100, Sylvain Munaut wrote: >>>> Don't build ohci as module for now. >>>> A fix for that is already in gregkh usb tree for 2.6.21 >>> Do you mean that as-is, powerpc defconfigs cannot build USB as a module >>> in 2.6.20 ? That is unacceptable as a regression. We need a fix in >>> 2.6.20. >>> >>> Greg, what is the status there ? >> Hm, for some reason I thought your patches were not needed until 2.6.21. > > My endian patches aren't, but Sylvain' are based on mines so ... Maybe > if Sylvain rebases his ? FWIW, the patch does apply fine (at least the first one, which is needed) : tnt@hitomi linux-2.6-mpc52xx-new $ patch -p1 --dry-run < ohci-rework-bus-glue-integration-to-allow-several-at-once.patch patching file drivers/usb/host/ohci-at91.c patching file drivers/usb/host/ohci-au1xxx.c patching file drivers/usb/host/ohci-ep93xx.c patching file drivers/usb/host/ohci-hcd.c patching file drivers/usb/host/ohci-lh7a404.c patching file drivers/usb/host/ohci-omap.c patching file drivers/usb/host/ohci-pci.c Hunk #1 succeeded at 238 (offset -73 lines). patching file drivers/usb/host/ohci-pnx4008.c patching file drivers/usb/host/ohci-pnx8550.c patching file drivers/usb/host/ohci-ppc-soc.c patching file drivers/usb/host/ohci-pxa27x.c patching file drivers/usb/host/ohci-s3c2410.c patching file drivers/usb/host/ohci-sa1111.c The offset in ohci-pci.c is harmless. But maybe the question we should ask is why would it build drivers/usb/host/ohci-ppc-soc.c for an iMac G3 ... Because that problem (ohci multiple glue in module) is there since a long time, just never spotted before. arch/powerpc/KConfig : config PPC_EFIKA bool "bPlan Efika 5k2. MPC5200B based computer" depends on PPC_MULTIPLATFORM && PPC32 select PPC_RTAS select RTAS_PROC select PPC_MPC52xx select PPC_NATIVE default y ^^^ This was added by commit c37858d333a50815c74349396e31a535f4128e0b on Nov5. and a patch to correct that has been submitted recently : http://patchwork.ozlabs.org/linuxppc/patch?id=8848 Sylvain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/