From:   "Li, Meng" <Meng.Li@windriver.com>
To:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "leoyang.li@nxp.com" <leoyang.li@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH] arch: arm64: dts: add delay between CS and CLK signal for
 flash device
Thread-Topic: [PATCH] arch: arm64: dts: add delay between CS and CLK signal
 for flash device
Thread-Index: AQHX0GRWh0F5UroaoU6nw30jLZ/2zKwD7Z+g
Date:   Mon, 15 Nov 2021 02:19:48 +0000
Message-ID: <PH0PR11MB51919E776D51FFCCE81586F6F1989@PH0PR11MB5191.namprd11.prod.outlook.com>
References: <20211103033838.16015-1-Meng.Li@windriver.com>
In-Reply-To: <20211103033838.16015-1-Meng.Li@windriver.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IfB0+rQpdUm1WVLEENBGqWEVb5wdOFp+P0E6YPFn1xJzo6Ic4uTMNeOXoftt?=
 =?us-ascii?Q?pNJv6TbNm9gfajVdpSD7ZI/9f3vMqZaO/JGa72ry4lJw0bKTyRIX3PEHrJyq?=
 =?us-ascii?Q?wQ+i3Xnf0Oj+yHrr8quVO0DoDVM+9HZLhHN2vI0KDX60gkzbiM00MRCa7JWs?=
 =?us-ascii?Q?B3JvAkxMZR5hBE6P+v15ajtt1FzM4X0BW0EVBUM5wb65QdvUPpSvXVtzJI1C?=
 =?us-ascii?Q?TiHm8qPL+82Lx/O0FlVQmLpaLDh0jf/nqhkebZsh5r1K/Jw3d3aUtk+Ai/mq?=
 =?us-ascii?Q?K1YgFbagPpL9NJLrklyO7YdvzPf+QK56o0ikyeHurC3K9aPLaVrWRcJcccrE?=
 =?us-ascii?Q?wWF+BdC7QMww2Jo8IxgJfwijJr0yrEpHPbXQMuhgla68ehrcsFSCDMmLASb+?=
 =?us-ascii?Q?g3dfVb9/ryD+WoCFnjp6HI3qk+nYcKLNNRM1WDJARiAMcYRq8szwl76XG3OQ?=
 =?us-ascii?Q?9wjWma7kQGG4AIgYWD3btiCN+CqtkNONe7nGpYRStFJFUEXmIHCy0ddvqeD6?=
 =?us-ascii?Q?HvrMscc3SYE/X5da9BeVKVdUyavGibq8znppFsI3OlnhO0xtxxFDmet4KdlM?=
 =?us-ascii?Q?NfVmujuYE7OLhNQMPWqat6Q9cr0JzBkFNxNljsM4fQSCuXCeflH/BzVR7xuV?=
 =?us-ascii?Q?n0+yYRw9ojQEziSEZ98JLH/RL2EhoXUQgw1FRmHOEYGlHYh7VcOhdc60h5oK?=
 =?us-ascii?Q?N3YYO8Ko1utq9JhiiCtGC/IKZXpPPMkI8eIAi2pB9jlh/XtJ5nketPyiHAfo?=
 =?us-ascii?Q?LYh0ZotgUGvM9RiaobCOr5C1ktiPpPjaDyaWGecJUvIkTHj5Lh/nLirxbjsX?=
 =?us-ascii?Q?gMlO4hrVDXz7GimIb02S/2bCcKdJfUjL6HXr1JXz4pd1qRb0fuVXXrk+q1bB?=
 =?us-ascii?Q?bKiIc79h8hcEHaN2GtUPHgmm01gV3lew5z835id/gtFQ2p6ZQ5V2nefs8jFD?=
 =?us-ascii?Q?6ipfKwr4FxrBDwq6miCu0VV0x5+lDNv93FvMGSdN+m1OY72PS59c3HPBjHxL?=
 =?us-ascii?Q?vUOwYkdMwM/kX5QZeaOe82d5eZ8Wif0Nw4BpNqSGbh/kKOKHB7WE3FvNSMi9?=
 =?us-ascii?Q?TejgGb59gq+wdLcgsK7kX8Gw76Oy7NfHjBV3U8o8Iij8yGqW3tr47O8qZOy3?=
 =?us-ascii?Q?k995oJD/BpiENf1xllUN4geEj3tdKv/VzJ/EvomEHpipACkyjwwdt/pZf1hH?=
 =?us-ascii?Q?DmTlGIZGPQjI018kwfNc/BRdBVgYaPgWSUPQ0sEwMMwOVmxvPHdBbGuTxSxY?=
 =?us-ascii?Q?NKXb8TaHKEznj9QAJCvrvtemkKCbnfwh8Y8Jj92ghBVBiscc/ByQSbKu66ZP?=
 =?us-ascii?Q?166rbuE//OD12YuuEkJ4GmGKhDkbBBDT91rGwej0mhjfDWu/wUELqnpk1XxA?=
 =?us-ascii?Q?ulFYEbHqf2nuIItjuNXDAobRDpzzhTbELPSxBttcCDxJ7sMNVbd7j6p+VOI1?=
 =?us-ascii?Q?qMr7EVtRv4AVlZzDrrG/1Bvj2nzeKtQWCXJ1XA9RBT4Glgo8cf/GSoTTyAAW?=
 =?us-ascii?Q?YJPnlkxyrXsVKJGZxONnuAQQmO63xSoQeZe/ZBRLHBI1iqKqi7/CK+b8H+1w?=
 =?us-ascii?Q?Yv5JohNVSFYb/2wGSBuQwSpPRHah3uUTj1Pw0aWAzmdh1aUzy329qcKqKnmC?=
 =?us-ascii?Q?rw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b35dd384-8eda-4c79-b15e-08d9a7de65c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2021 02:19:48.0340
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qhdGGepdlpWlvOq7cOqYLzz3j6KlSnbAK5ZJ+qmDNqgmTNV9tpOI6A/2UQIO7D2hnReow/StYsqtwppzm5KbTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109
X-Proofpoint-GUID: 8TvEGEjZ19Hc_i9qF2HYeTM5b2Tf0rqB
X-Proofpoint-ORIG-GUID: 8TvEGEjZ19Hc_i9qF2HYeTM5b2Tf0rqB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-15_01,2021-11-12_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 priorityscore=1501 malwarescore=0 mlxlogscore=999 spamscore=0
 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 mlxscore=0
 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2111150013
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Is there any comments about this patch?

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Wednesday, November 3, 2021 11:39 AM
> To: shawnguo@kernel.org; leoyang.li@nxp.com; robh+dt@kernel.org
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; Li, Meng <Meng.Li@windriver.com>
> Subject: [PATCH] arch: arm64: dts: add delay between CS and CLK signal fo=
r
> flash device
>=20
> Based on commit d59c90a2400f("spi: spi-fsl-dspi: Convert TCFQ users to XS=
PI
> FIFO mode ") and 6c1c26ecd9a3("spi:
> spi-fsl-dspi: Accelerate transfers using larger word size if possible"), =
on
> ls1043a-rdb platform, the spi work mode is changed from TCFQ mode to XSPI
> mode. In order to keep the transmission sequence matches with flash devic=
e,
> it is need to add delay between CS and CLK signal.
> The strategy of generating delay value refers to QorIQ LS1043A Reference
> Manual.
>=20
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 3a669238a0b8..3b1a31a063c6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -98,6 +98,8 @@
>  		compatible =3D "n25q128a13", "jedec,spi-nor";  /* 16MB */
>  		reg =3D <0>;
>  		spi-max-frequency =3D <1000000>; /* input clock */
> +		fsl,spi-cs-sck-delay =3D <100>;
> +		fsl,spi-sck-cs-delay =3D <100>;
>  	};
>=20
>  	slic@2 {
> --
> 2.17.1