From:   Bernard Zhao <bernard@vivo.com>
To:     Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        John Clements <john.clements@amd.com>,
        Jonathan Kim <jonathan.kim@amd.com>,
        Felix Kuehling <felix.kuehling@amd.com>,
        Kevin Wang <kevin1.wang@amd.com>,
        Tian Tao <tiantao6@hisilicon.com>,
        Evan Quan <evan.quan@amd.com>, shaoyunl <shaoyun.liu@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drm/amd/amdgpu: fix potential memleak
Date:   Sun, 14 Nov 2021 18:58:50 -0800
Message-Id: <20211115025901.2598-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4AsGnTKUBZZPStOYN1ckNEnNHeIW/F00308f7qgDKPC3395WBOxLRwomnyFl?=
 =?us-ascii?Q?F40z3rQBZd/ggmFe0qGajbWVGq3W7N8cjuBYPUCiTdg5Cqgyx67shMtzbr1B?=
 =?us-ascii?Q?97faOycMt7q6TFoE2P5INsMX5Yz/4z3x549gp9m0zLNOKFYH6gB4Os0Dv+7H?=
 =?us-ascii?Q?eknQWSO+QaSnd1uEeF37grDI0s6f8tTlA2FU8Z+Wrd9YpBQiu1G91DgK2mlH?=
 =?us-ascii?Q?HC1F5rkWtlyq8zTpMBRv9XCAaYVhrQndNgzMRDUOg/paeDGArIudB97c/5ON?=
 =?us-ascii?Q?zIRro75kWQZ3TpxmfMG5qd+tQNFWkMMyT9EwAu74L3HL1dkntt8IUlmYUC6b?=
 =?us-ascii?Q?x40ASwIFZk2uQ9nWtFmy+csTnlFgkxrBBkz7gIDNwHjyS6b1Bbj2ckr7VyNp?=
 =?us-ascii?Q?2v55NnaPM+SzqOzNjvCaz4TqzO0zUo4X1qfBKHNM+11UuouhHbVG0jMjudhS?=
 =?us-ascii?Q?u2JqSsK9yJMFhPFUmwZLqqlzkH1Iwvv5FwVWa3ZKTEBKnK3vRrWEM18jpWv2?=
 =?us-ascii?Q?rTvVAkGDoQo9oO91/o/JtzD/rH91EDBwcmu477bbk+FX/mQ5uftNHzc9fg0K?=
 =?us-ascii?Q?y0DSnqExCZSKunCxkZ5VhxboR+5h/EqUbgvZeBIY8Z1YKFPtlfkxtOzRGFZM?=
 =?us-ascii?Q?19nB2SzzlSgVeg+MNwFdcxjQ+uzdt9H4hUlrYZq9ebqLBg2M+eVJpQvCyj3e?=
 =?us-ascii?Q?/JaMJiZ6rtBDEJ5lPRJ7eDICx8U9AiQ0mGV+gk4bNQ2HzYoWF5upLYkCK7pp?=
 =?us-ascii?Q?RV8tF6FDaGboATjuNjWC9Z1QN6iPc8uy3R/NFN1ICswu6zmp38+E8sgw2SIy?=
 =?us-ascii?Q?peqx6vjgPMQQzb5TTLZPKVTTx53AC6VRCsj/FSmxXR5t1u5fmjmQa6/4LPAm?=
 =?us-ascii?Q?AVN9vVkiCtxIuBee5zwQWvVkNXYBnmmHwALOsMNLUpCSYTWbrEL1wsB0mUqv?=
 =?us-ascii?Q?KCf3uLMpHvrLVjAIoibKjTyQURugYgYsgkbpRb7NsznuoQAYDCqusgaQ9M4Q?=
 =?us-ascii?Q?3anFCX99V89X++ztP06VWfHGGMDkQL1yrnKjaB0Om2J2HSvqr75gO5M+bzw6?=
 =?us-ascii?Q?YrB/bIzC2JtKJnyxOddrYeqeQOAldHBOIRpuyL8uGzBzK4Ws4fRGHqRLxl1N?=
 =?us-ascii?Q?/ZRh6416j9u9xQOoPclAFCc3zmWGB9vND8oWGxVyXc0i9Cc+nHUCvU/5G0IY?=
 =?us-ascii?Q?hYsWRjCFk8B7Ixjfq8C0ZVzdWkVNyaRgyKqAINOUCrdo2Hy82aqgLyIwH5wD?=
 =?us-ascii?Q?YHICfDSdHMyOXlZs1BsrNsj0zONEg51hKIKJG5yx9pVMoAxetVjmYpetmvg9?=
 =?us-ascii?Q?xr+mpt6t9bYQVf3l8lYL2EHry6wadkGtvW2AtjNbf6mxp9miWLmc2UK7FG//?=
 =?us-ascii?Q?+S7jy5/2LWpQe2m/OVB2DqR8Oau6L4Sa27XeU9MBa1LhrGmGt1xJcNHnLmZ3?=
 =?us-ascii?Q?qEREX91o/CNG0ShigbTzaJWGPbsbVeNs2gYahbXOs95OCtx/zB2uEH1lmlXu?=
 =?us-ascii?Q?bV7c3QiTk6rZ0yoHmEOpHxlNH+6Rrz8oz5uzWcZ9qPm2LB2R/01bwy/UZtge?=
 =?us-ascii?Q?WjOXgTuDAMfo//AEfp4LYRtL+BeVTPpSwASjCF++jwU3u/jbmSZb8YKIowXo?=
 =?us-ascii?Q?t5EOdY/13vciQraEqSBwe/Y=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abc96290-75d6-4456-ede3-08d9a7e3ea3e
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 02:59:18.2089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: paYU84gXcavc6ZHpx/Afv0m3FtAOKbtcsHtE2j/ysnXtT5NRA6Gop1D6GQynJ8jBo9bOJJ/cr7JGRkFFxByY0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2903
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed
There is a potential memleak if not call kobject_put.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 0fad2bf854ae..567df2db23ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
 			"%s", "xgmi_hive_info");
 	if (ret) {
 		dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n");
+		kobject_put(&hive->kobj);
 		kfree(hive);
 		hive = NULL;
 		goto pro_end;
-- 
2.33.1