From:   Bernard Zhao <bernard@vivo.com>
To:     Song Liu <song@kernel.org>, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drivers/md: fix potential memleak
Date:   Sun, 14 Nov 2021 19:18:17 -0800
Message-Id: <20211115031817.4193-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lg8B1mnL90YjnebTJj8+lNA4cgn2O3civegyEa+tg6+M5RYOOpowp2+Mla0F?=
 =?us-ascii?Q?78er4Sv6SQnxFgmpAP+8KL3OA/kbvzFiBN51yeClFec4rIgY5SaAN0UWzIXH?=
 =?us-ascii?Q?K24lS4Ak1vfFFKDVxx0GeUU8/YuWDr55aOeM6Nsq9xvQGfUzmzjnINtriTXl?=
 =?us-ascii?Q?T/PEWPoZ0bH6D72M0RSOy98E1W8+2I2wh5Zy+5SOEPqKqxMuYT7ghxsjw8ZK?=
 =?us-ascii?Q?qh7TjPud7UW+oSkxOu2c+7mP5G4dzaTCoAbpU19IdMfSBvq1xsw0x8YsLGvl?=
 =?us-ascii?Q?oXo++xi7PstTPTxN0ZY8BaoWq3jXiU1b8LDi/Evx3K8WWTIuY6akItnh8jYd?=
 =?us-ascii?Q?dUSW7koSc4EvyPYVKNUx2zaxwmhV6mt+DBctXnpJL0NM93CbQ9Fk/O4GCNAq?=
 =?us-ascii?Q?KG0HQ2VaCCbJaE5dRz0jXwT22pUjurM2pa+p5MnTL7xOU7gIXCi1zJ0S7ipb?=
 =?us-ascii?Q?AaXqt6h+r9vh8ewr5tt6PjjFG/Sye7ZMxXVJOpwE2iNp823KwNlt9HTvVJ9e?=
 =?us-ascii?Q?8bZxHFtm9gTuHeQj5BM1RfYSBQXfYMAztMYB4QcaC8kJlp3krRH5uGWx6q3z?=
 =?us-ascii?Q?z/7o4uKJDQf7tiiHgqfVmT9nKGffoe5KQupYAOpPBW8dw53887exb8CqN2mm?=
 =?us-ascii?Q?8no+Amjp5ACJT+MTYOCD+RxYs55jF+iRIcoTriY+eXL1mDf9M+XctFxHbk3h?=
 =?us-ascii?Q?GqpLVakZuVeIF42NLQdfjmzxPfvGr+NzdXU8qDdG6R45fX6FhyFbkVpXxaJh?=
 =?us-ascii?Q?8c/VopcruE1QRynh+cR2jve1ntkO0Ed1O+GIMSnAbO9ddfNLH+cYIUWcYBBP?=
 =?us-ascii?Q?2tjbKy6EI3qdxAjCWj67ADq7PmK6lC44prEtEDZAn1dgV2tHMIHKWSWqR60F?=
 =?us-ascii?Q?l50cHAObpiXGNhY/hq0Kf7+9bOHObp6Wg6iDCQWSt1KJ296qblhbXGxpQ5Zr?=
 =?us-ascii?Q?CKg5kEifh8UZXWAEs5Oped8oBDTWmAApHubMHq7x4XLBTgmG6TuUbTiiQWRh?=
 =?us-ascii?Q?tdH0ahGWdVzCejBpH943EsJdZ9v/uCvdnGKMQbVBffcWzPOf/SDujnE9L/BQ?=
 =?us-ascii?Q?xhrJch4A4RVkvpHDm2dmPTrG6y7ZH6FWAsOK3ikKEZCYNmEI8eapIGtd3LlK?=
 =?us-ascii?Q?nRV6SLnUjg7NBPNcjtk5Z8oGNjG3yeYNXRaxelzadvsBE4oWfEYFsQgq93q3?=
 =?us-ascii?Q?2BKmNmC4bmL/ypg2pmdxkzW/HT8Yk41st0mu7n4gUFRS1uibM+kAHgITaaDp?=
 =?us-ascii?Q?R8dOVmITJD+2p9aBkskJFP2IyyNQjuxBJmxqCTkPtx0HNWerHpyD4m0LRlUH?=
 =?us-ascii?Q?pP8OteJgppBGdJ0PjiioXmBYJJHNr11EAHH8lAAs3NYgw/cB8QhDnXocii7i?=
 =?us-ascii?Q?SxJkM4U4Gu39U1t/7V/VyiKWk9RGCa4YU3rIzPaQFh1n3/ejWVpdWnuAVPYB?=
 =?us-ascii?Q?hwQoJ336UJKbAgksmIqn/N2It5HXGFcGT80f12GNDpUng/nZ0wk35N2SOjQi?=
 =?us-ascii?Q?zY3VbdVOQYBhpVjMh+4roQrbG1LWSKrGPg7M3umWYvMb8hQVRRp/VRAvFZJi?=
 =?us-ascii?Q?wmLA96ltBIHe+pNxU3T/JjScwywrHKCQU8IZFvEGBIDvWweXIfBuFhxNGA4h?=
 =?us-ascii?Q?5MLJnfqlcnwIE3PgSDVL6eQ=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 936951e4-188c-4fc6-acc7-08d9a7e69866
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 03:18:29.4681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IFdKsi/LIhp++o4QB7rEQeSFo9u0LI48cCizZ0CouvWOsQc57VqNgKrYRk0oym6pJbMaG4l2YLwzjZnPbdEw8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2936
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In function get_bitmap_from_slot, when md_bitmap_create failed,
md_bitmap_destroy must be called to do clean up.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/md/md-bitmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index bfd6026d7809..a227bd0b9301 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -1961,6 +1961,7 @@ struct bitmap *get_bitmap_from_slot(struct mddev *mddev, int slot)
 	bitmap = md_bitmap_create(mddev, slot);
 	if (IS_ERR(bitmap)) {
 		rv = PTR_ERR(bitmap);
+		md_bitmap_destroy(mddev)
 		return ERR_PTR(rv);
 	}
 
-- 
2.33.1