From:   Meng Li <Meng.Li@windriver.com>
To:     thor.thayer@linux.intel.com, lee.jones@linaro.org, arnd@arndb.de
Cc:     linux-kernel@vger.kernel.org, meng.li@windriver.com
Subject: [PATCH] mfd: altera-sysmgr: enable raw spinlock feature for stratix10 platform
Date:   Mon, 15 Nov 2021 11:44:55 +0800
Message-Id: <20211115034455.19240-1-Meng.Li@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ysdIELAyzgS1W6ZLyteZ7M48I2hhEvOVEZNSU9DZogR7KKQYRNoOuoCzEAKA?=
 =?us-ascii?Q?IJodnAqVEFbkST/GCE10znXT0KuLZOb3od3+sp38CxumvATKBKdJrq1q/ogT?=
 =?us-ascii?Q?KRjsm5uhsDEM0TBrN5UNiWkT++PMkhRLKI4zdfiuyrekc/IQLs+O/a9DmRWJ?=
 =?us-ascii?Q?WPO54wM1whJ67axZYxxAC7er2dt5vRJbhFIBNJK23F5k7Oo3hhw/n6cJ/XpW?=
 =?us-ascii?Q?66DzMth/9nKIsZe0eWaj+cWn8/x/VVPdmIIz5R9A4uz7tPp2hYRY8y/+LmSs?=
 =?us-ascii?Q?MsKkm26mT5AiOL0sF64Tmh3zWazz2khJEYuwU+kDPxbQJp/8CXhRFctnK0jW?=
 =?us-ascii?Q?6HdV5hX1HgOtB+90n1ImyzUhGO3n/MpSMI9KDbf/1QDlgE2hBjmxbKkm3N4S?=
 =?us-ascii?Q?fYO9/RjCFOuIqPBuWWHtyfQfG5o5u/kxDSbV1NwiPfDXPr0FMg/uOb6DrcpX?=
 =?us-ascii?Q?44WX0jJ6ltrbK6WtdUa9HoLKsk83HCreppQvdHsgOm+YMGLOUGNJomWjWYig?=
 =?us-ascii?Q?DNShhuUbaaUKoUBwZUtCmc8Ol20mQcGC9+/2p53Yrcoeg/j8hbHawexhhmuu?=
 =?us-ascii?Q?rgl+DDowVAKGs0FmPaIRtMWPBs0HOji9CzPwUT+s3XVL+CTvxsoyWq1IZj03?=
 =?us-ascii?Q?FveRrbl4oeFvN8rz85pRFU6FCZsHbqrQYEpMEChRSazBijW0wiNzHv3EzC62?=
 =?us-ascii?Q?sY0vrwUUR7nNL6J8Kr06ddSUDvGxGRbL7CMXPZiIwdnctQm9bRpUawRkPMM8?=
 =?us-ascii?Q?SnmXk9GIa+MyeienYYoD546BV2culp716VLJ1+LnnqZIMWh5JXoXZ7Z/3/2j?=
 =?us-ascii?Q?dzgPwdt0dSY+TzEHT4SmIDSaP2A3S0o9MgVVzKqCzziaA0nyFYIGPqkhBLeY?=
 =?us-ascii?Q?9O+J/+xbH6s22HfSU2BhZls7465JzoKvoAR1u8cQzP7DXytWwoBjWnuau/bs?=
 =?us-ascii?Q?kkgUV8Lze5vCwg0nnAkZHZdguocnZPhdVViRvPqzFJj3XNMWIxpqU+nmOEOj?=
 =?us-ascii?Q?I+LoekxAQWMSzEmlLXcoqwM25QKJ/aAWoc4QycxbWC79urPIn8WssLsGACHB?=
 =?us-ascii?Q?lhybHltWy2VzZqGMRvVbpysPZfdnBy8uSNtUX67JTj8ooVlmbX63hAEhGFaj?=
 =?us-ascii?Q?dijr5WpK9CO4CKZVdnLmyfcEx8F1JnGI7lRuA9mqHBBw0EDnVb+5mjnOfO1K?=
 =?us-ascii?Q?fwJ7XyEPUjrBca/x2a5zUjmL+eQkbJH80TlHuQT5FBzY3R/yySODw2jwlDrZ?=
 =?us-ascii?Q?HVi2t4F7NJGyUQpfwjj71z8vn84kefJeXdVNwp3WIJdM6VrfB31Y5uq4nse6?=
 =?us-ascii?Q?Kvyb3TtyLCgy8m0CvLst9HFf7wSo/HU6WodEn1fAsS7EUVAyWeqd5c5vie0n?=
 =?us-ascii?Q?YxoilpcOfDkI0Q5cxxwTotNx80YTCJR2W7qcX/iPyw/GpFSJlHv9Q4OQfLVw?=
 =?us-ascii?Q?EWewN6QGxUsANB9wOy4CEow7grFdOdmvILuMqlH5TrSQghks0vINNz8csNX8?=
 =?us-ascii?Q?d7YFOVSieT+cOu96wfnFgfajWUVNr4wrnFI4tAA3BNgv9mpkt3SMM29jlrTC?=
 =?us-ascii?Q?+wKpmQBiU8nvzBkTKKVhev3JXuxBRA73cfK7SViLjcVObTPVkKS/tQnS9LXn?=
 =?us-ascii?Q?tp/J+Xr6FjAX/eKuClbDHPA=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7a2222d-d226-4544-0102-08d9a7ea5437
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 03:45:12.8554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cS4V1HosTS8czZMnZJqEWuDkT6EvVdQ3QJ0hYxgQubvgexh6Ewi5uJgrwuhjgeBPM5Fin85ioU83X4/cjsanFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5048
X-Proofpoint-GUID: FY0IhUNR9SUm7vaaSHW9Im5INHE_La9R
X-Proofpoint-ORIG-GUID: FY0IhUNR9SUm7vaaSHW9Im5INHE_La9R
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-15_02,2021-11-12_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 adultscore=0 clxscore=1011 bulkscore=0 mlxlogscore=942 lowpriorityscore=0
 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150019
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When booting up preempt rt kernel on stratix10 platform, there is
below calltrace:
BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper/0
Preemption disabled at:
[<ffff8000100b25b0>] __setup_irq+0xe0/0x730
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.78-rt54-yocto-preempt-rt #1
Hardware name: SoCFPGA Stratix 10 SoCDK (DT)
Call trace:
......
 ___might_sleep+0x144/0x180
 rt_spin_lock+0x34/0x9c
 regmap_lock_spinlock+0x24/0x40
 regmap_write+0x48/0x84
 a10_eccmgr_irq_unmask+0x34/0x40
 ......
 altr_edac_a10_probe+0x16c/0x2b0
 platform_drv_probe+0x60/0xb4
 ......
 ret_from_fork+0x10/0x38

Because regmap_write is invoked under preemption disabled status, and
might trigger sleep. So, enable raw spinlock feature forcibly.

Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager ")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 drivers/mfd/altera-sysmgr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index 591b300d9095..8aad5bbb13b3 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -83,6 +83,9 @@ static struct regmap_config altr_sysmgr_regmap_cfg = {
 	.fast_io = true,
 	.use_single_read = true,
 	.use_single_write = true,
+#ifdef CONFIG_PREEMPT_RT
+	.use_raw_spinlock = true,
+#endif
 };
 
 /**
-- 
2.17.1