Subject: Re: [PATCH] of: make MAX_RESERVED_REGIONS configurable
To:     Calvin Zhang <calvinzhang.cool@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211115063521.3457302-1-calvinzhang.cool@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <18eb2d82-d3b3-79ec-9c20-c5c5cf5cab52@infradead.org>
Date:   Sun, 14 Nov 2021 22:40:29 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211115063521.3457302-1-calvinzhang.cool@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/14/21 10:35 PM, Calvin Zhang wrote:
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 80b5fd44ab1c..591b2c4d9dd0 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -73,6 +73,16 @@ config OF_IRQ
>   config OF_RESERVED_MEM
>   	def_bool OF_EARLY_FLATTREE
>   
> +config OF_MAX_RESERVED_REGIONS
> +    int "Maximum count of reserved regions"
> +    depends on OF_RESERVED_MEM
> +    default 64
> +    help
> +        Reserved regions in /reserved-memory node includes static
> +        reservations with fixed location and dynamic ones for device
> +        cma regions. This parameter sets the maximum number of reserved

	  CMA

(as is used in mm/Kconfig)

> +        regions in the system.

Also, all 4 lines of the help text should be indented with
one tab + 2 spaces, not all spaces.


thanks.
-- 
~Randy