From:   Yihao Han <hanyihao@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Yihao Han <hanyihao@vivo.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com
Subject: [PATCH] net: fddi: use swap() to make code cleaner
Date:   Sun, 14 Nov 2021 22:58:16 -0800
Message-Id: <20211115065826.5221-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fw8/AewPLZ8J8rJKvCoJ75TqEhFAJ+XbAtZY/o1s7bqP3MQTjy65NCrDC0NE?=
 =?us-ascii?Q?xguQXOdA6mzSgnL6ZAKsrN3j/8s+3SG0tW7DL191cVacmrbJUcVYtLFBDDel?=
 =?us-ascii?Q?1V0xCpxRmUCkldMDaseyk/mRme/5sB7On1uLUt6C6FG26HpTtxWWEYCtO40/?=
 =?us-ascii?Q?bdBj/h1YRtbBZ/++es+9s+NIX2KM1vVN5bc47OswkOzHpHKGmRqBxGMkKioE?=
 =?us-ascii?Q?2PlBsVLDMfuMxuOQ1TXSMfAQ/6/KkfpCp8olRkXxvaoUDMdatd2fVeH1Xm6I?=
 =?us-ascii?Q?uIRgQpLNe9rwoBKJf0i4O2P3VvHD4IRNHPYpJZI+trB5o89gOlC2TqYHN/Xs?=
 =?us-ascii?Q?9ywmJ8BXCs9okgYr827T7AAxo8gfl6aW+zJ0ZM2PBwYJ3LwZOyPuNCGRe1tW?=
 =?us-ascii?Q?cVezHRVmU/lPkP5hbOx/RwwEtMdxJkRUdVpX69ONb9O1MMMUp36/L3E0UybD?=
 =?us-ascii?Q?yzpoL1NPbP0HvJUjKpVntMhwNKeO09TpUrEM9MMiOpsECT01SSeZnUgeVCt1?=
 =?us-ascii?Q?myPA3vdsRuAYCDpSetgWSLbwYlgKU/9x8TkOPHT3ngNbuRGKSGJlrau2j1p7?=
 =?us-ascii?Q?gyVu4KuYB0/92NyJ/ze+cFaySV6OV48r5nH1jXDChf0ThiNB4ns7fLHMjWyD?=
 =?us-ascii?Q?sM649H/nKtp10Rf1JVpnqXIOwloAbhodRwdXfDtE4EY9A4KMApNSqbzeszDR?=
 =?us-ascii?Q?W0VsVay3MQ7QaMg9R0IhJwnsLiJStZAoP/09rxh6VJUHBBKF6j3cd4wXONI/?=
 =?us-ascii?Q?1ryIt4RXlEBJvFZLV6AwEijHjbbEEwa0aLJaSVEP27OgFAyi3jczTxD0UEp2?=
 =?us-ascii?Q?ElHzAAzaPEApkOt8dUAXaUi2kZ5wMNdDcAhky3j2qEwUk9vPHd2W6NuFC5kU?=
 =?us-ascii?Q?fARABVOXRZ0RpH6d9nrad0ngFyNrBXGCmMJ8vfF5a5h7Cs4okfBuxUVJc/r8?=
 =?us-ascii?Q?zWLYjCiFm9a1njlKD8aoTMARmP5tlhAHN05e9NcYnkn5aD5Q42XUK5fIYcTA?=
 =?us-ascii?Q?u8Yktjc7PSC2EP5y892MxBWMwSQ+C/90PJCcoOHf5+iseYYmUGS8ojAj1dP7?=
 =?us-ascii?Q?4bfxJ5ygtGSs//gMAQMr9w575EjTfO0ahGeZt/+XLMN1npNh1oTI2lFwOf78?=
 =?us-ascii?Q?NwpJSU8CkKN8I9YTOsWznkv6pkWX3KEz6f+Hnt0L5Aep2LfT5OpyaCrLmTUX?=
 =?us-ascii?Q?JmDqf62gAuXrjds0vxEgNBOl51kk9CGIneYumTFbxWfAdVd5r0uAEpYdZ5rc?=
 =?us-ascii?Q?H0U6YNtrAI0nNUBHQgchfyNiBEJfKcIfsAEOaS63LdX94J8iqcMg08Jh3iCE?=
 =?us-ascii?Q?zh/Xhh3sX44aSh9IiOO+VhHaPfi7bPJEGzDJxmof/fT7HLI8kdKDhfM/2TPs?=
 =?us-ascii?Q?WW65zi3PGPsAkuNu9oTQNB1BW4AMsXhK9dEcH2JQwqhElatRVLrFp9VA2BX3?=
 =?us-ascii?Q?P2saQGs0rftkcuA9R6fZmPU38c0h/b6ENwh08WhqPEbxryEPlxAuElNDzGCa?=
 =?us-ascii?Q?N0oQjpopVY4P0v/PmPCeBOME9uvjEZOawLyjYvk+A8k5+prcYMhN4s0K7Nl1?=
 =?us-ascii?Q?osPVSJtu4abO10FVChagKWfs594bIdGRpmfYgqAQd2FX8VRA5DbQNVzxIMRR?=
 =?us-ascii?Q?C7HY1vDynL4jMjgRuBGQZqA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31f76079-1556-46e5-6669-08d9a8055a6a
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 06:58:40.2398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VVqLlg4+mUEB/pC4jskPlnVIomGd3jkhVphYcSU7ltZej4yZM1R1dpgb2yZ1L3r5wy85DtWoaicXPCeTUiqXcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3951
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/fddi/skfp/smt.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/net/fddi/skfp/smt.c b/drivers/net/fddi/skfp/smt.c
index 6b68a53f1b38..72c31f0013ad 100644
--- a/drivers/net/fddi/skfp/smt.c
+++ b/drivers/net/fddi/skfp/smt.c
@@ -1846,10 +1846,10 @@ void smt_swap_para(struct smt_header *sm, int len, int direction)
 	}
 }
 
+
 static void smt_string_swap(char *data, const char *format, int len)
 {
 	const char	*open_paren = NULL ;
-	int	x ;
 
 	while (len > 0  && *format) {
 		switch (*format) {
@@ -1876,19 +1876,13 @@ static void smt_string_swap(char *data, const char *format, int len)
 			len-- ;
 			break ;
 		case 's' :
-			x = data[0] ;
-			data[0] = data[1] ;
-			data[1] = x ;
+			swap(data[0], data[1]) ;
 			data += 2 ;
 			len -= 2 ;
 			break ;
 		case 'l' :
-			x = data[0] ;
-			data[0] = data[3] ;
-			data[3] = x ;
-			x = data[1] ;
-			data[1] = data[2] ;
-			data[2] = x ;
+			swap(data[0], data[3]) ;
+			swap(data[1], data[2]) ;
 			data += 4 ;
 			len -= 4 ;
 			break ;
-- 
2.17.1