From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        linux-kernel@vger.kernel.org (open list:LOCKING PRIMITIVES)
Cc:     kernel@vivo.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] rtmutex: fix boolreturn.cocci warning:
Date:   Mon, 15 Nov 2021 15:04:10 +0800
Message-Id: <20211115070411.6842-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?77hM8kB+EWzw8v6MAnf0teWF5Hit2OCz1hYqWvx07yGJmD65OAPMtUgA2/IK?=
 =?us-ascii?Q?vGgLmUbe2n/6qrqw0oKb6PnxblrqNaHN3JvTkh5qrf0nz33RinmExHsPZ7/v?=
 =?us-ascii?Q?vFLJy6ZH0E7yrFypv57d8x54b1uYB8WcFISCPqk8ZZBXPjLA0nIXLrOY/4AA?=
 =?us-ascii?Q?dNizwvUoSZin1hytluTl0LIFtPlpe2iSw4oTFfeQXIJmfzqjbGC7azn1K4Kb?=
 =?us-ascii?Q?MqsvYY1PejK/bb74vy7HIZJRR+B/XbwxZ+Uz2UH4SNtuyviJ0Vx63+FJT2RQ?=
 =?us-ascii?Q?fiIu5Q7QohbcU9B26USSmsuhVDYPGaTLHR5kZ/XUZRE5CFGorvjqTK7WlSyc?=
 =?us-ascii?Q?8mql4JQWCB5z3WIoWlDIF/gfosv492frxXT5a0tO854Qnqau6iDevEKZoLGO?=
 =?us-ascii?Q?kQdeEmxWv53P5Y2bUclAVAxxeSDjAgMCcoYPleYXMRGmY9apcvoqR86hMDyT?=
 =?us-ascii?Q?bAMzyOCbKNmM9pvXyt91s+8CrrU6FUMWwrwJ+fV2v9LHHLChGwZlZhiR1rRJ?=
 =?us-ascii?Q?38Tc9AmoH5qUE1gKGwtyt4xUUHGEZy071JUniIAP8ZGijNmmnefhbup+MGCG?=
 =?us-ascii?Q?/K37dQfP19i/jHxat6ANHoCglL8qDQGUZbl96Gty0dVYmQtr8t8A2T4YYXL3?=
 =?us-ascii?Q?eeXS0RXHP466xPsyhPj8DvbX0vjY24XvJzSKGTERPXTPjCViuAWyW6HlX7uK?=
 =?us-ascii?Q?VWMQm/hv6mTaSmo/goelJyamb/dvu04RwzqjcNNqRRJFZPdBQtMYGelADymt?=
 =?us-ascii?Q?ZinArKX6d7NxggHmGkKT6D5UNuCf5ooDg7Vo2xszadjxjTDBt4HAPOigAvUb?=
 =?us-ascii?Q?8lpHB1kosOJmf0NjHbXahes5nx6zBb1RdGznOVAuP4HaB8eBLaUtjow55OWl?=
 =?us-ascii?Q?a+bADbAGsUM9lP33uWxrYMsc1BQL1AFJ52BNej4kx2Rkzuh7i9he2Tg+VRjH?=
 =?us-ascii?Q?vWeIDssPO5WYeiPi0u2XwOqgVxrt6AEMkYUfDAiIpW9JP6TePT6ct+/i50e8?=
 =?us-ascii?Q?DrpYiCtyjJ7Zq7vx86u2gPssK4b6GUmhbiITQ7Qty9N9PDDxR6xoUjBo4yF1?=
 =?us-ascii?Q?PVQDtLgF53WtHV1HlCue2fCs9bcD17QxklbphTQYdNTw2l+Xnfr5Hcbgw35+?=
 =?us-ascii?Q?27+Zaud0SmFcA0zY/OovcUkEfB6IqHr6rjAXgFYfr+M/UEOIyeKomrae8vkE?=
 =?us-ascii?Q?p/IZKJNmUIVkbMujrpF0+6HRK+p82HVdAmx+LVPZmaAbD1AUqYYI7Q5d3nbV?=
 =?us-ascii?Q?ZsdNfv/sUJ13fFEuATXgoGGS22ZTeigUo4fFVXYg9KQt+d2CsGJ9nsT3+GI8?=
 =?us-ascii?Q?Ljqj2Ar3VW7C2kXXXQ3/rYoOLsMm05yjXHVXgoAViN3/O7/CZNWnFhhio9b4?=
 =?us-ascii?Q?/iQcnwwtIJ5JuXtG7rGAyUn/Towczd5DOfsqGicmOP9tzCY0UX9h2mZojCGi?=
 =?us-ascii?Q?F0b07f4RAdoU/wNABWlndBHQqwcGytptU+YHt5sSaEczzuj2Ob5Dwak1JBHy?=
 =?us-ascii?Q?jWJnvFcK7UiWF5tzie6WpWAdLxTUezd672xbTSsw+FEYD5jbtIaymwIDMbK5?=
 =?us-ascii?Q?0STjdZ9Pij+y0I6AMoxytQoQUykJazjlUkAVAJ4C7CRa5NhGT/WcrIr/lAJD?=
 =?us-ascii?Q?Jszh8OobdNAnPZwUcLnmkks=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d92de98-d14d-4c9a-ac2c-08d9a8062eea
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 07:04:36.1516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cUqUSDW7PJnShlN/CqUCOX50xpI7uhdFth+aMlPH81KKn13jX31MQ+C/gNEVVlqFowFv2HX2cKajkmuNLFryeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB3428
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following boolreturn.cocci warning:
./kernel/locking/rtmutex.c:375:9-10: WARNING: return of 0/1 in function
 '__waiter_less' with return type bool.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 kernel/locking/rtmutex.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 0c6a48dfcecb..fbdcf61b6824 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -372,24 +372,24 @@ static __always_inline bool __waiter_less(struct rb_node *a, const struct rb_nod
 	struct rt_mutex_waiter *bw = __node_2_waiter(b);
 
 	if (rt_mutex_waiter_less(aw, bw))
-		return 1;
+		return true;
 
 	if (!build_ww_mutex())
-		return 0;
+		return false;
 
 	if (rt_mutex_waiter_less(bw, aw))
-		return 0;
+		return false;
 
 	/* NOTE: relies on waiter->ww_ctx being set before insertion */
 	if (aw->ww_ctx) {
 		if (!bw->ww_ctx)
-			return 1;
+			return true;
 
 		return (signed long)(aw->ww_ctx->stamp -
 				     bw->ww_ctx->stamp) < 0;
 	}
 
-	return 0;
+	return false;
 }
 
 static __always_inline void
-- 
2.20.1