Date:   Mon, 15 Nov 2021 15:14:21 +0800
From:   Calvin Zhang <calvinzhang.cool@gmail.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Calvin Zhang <calvinzhang.cool@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: make MAX_RESERVED_REGIONS configurable
Message-ID: <YZIIzcO+MPbNH3qR@debian>
References: <20211115063521.3457302-1-calvinzhang.cool@gmail.com>
 <18eb2d82-d3b3-79ec-9c20-c5c5cf5cab52@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18eb2d82-d3b3-79ec-9c20-c5c5cf5cab52@infradead.org>
Precedence: bulk

On Sun, Nov 14, 2021 at 10:40:29PM -0800, Randy Dunlap wrote:
>On 11/14/21 10:35 PM, Calvin Zhang wrote:
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index 80b5fd44ab1c..591b2c4d9dd0 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -73,6 +73,16 @@ config OF_IRQ
>>   config OF_RESERVED_MEM
>>   	def_bool OF_EARLY_FLATTREE
>> +config OF_MAX_RESERVED_REGIONS
>> +    int "Maximum count of reserved regions"
>> +    depends on OF_RESERVED_MEM
>> +    default 64
>> +    help
>> +        Reserved regions in /reserved-memory node includes static
>> +        reservations with fixed location and dynamic ones for device
>> +        cma regions. This parameter sets the maximum number of reserved
>
>	  CMA
>
>(as is used in mm/Kconfig)
>
>> +        regions in the system.
>
>Also, all 4 lines of the help text should be indented with
>one tab + 2 spaces, not all spaces.
>
Thanks for the review. I will send a v2.
>
>thanks.
>-- 
>~Randy
>