MIME-Version: 1.0
References: <20210629103700.1935012-1-geert@linux-m68k.org> <162500112137.438178.14586324457676666976.b4-ty@chromium.org>
In-Reply-To: <162500112137.438178.14586324457676666976.b4-ty@chromium.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 15 Nov 2021 08:58:51 +0100
Message-ID: <CAMuHMdWwDK0bB2B7iFXqMhkZrmw26vKDFZEv+z+mYYTavp5-Eg@mail.gmail.com>
Subject: Re: [PATCH] pstore/blk: Use "%lu" to format unsigned long
To:     Kees Cook <keescook@chromium.org>
Cc:     Tony Luck <tony.luck@intel.com>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Kees,

On Tue, Jun 29, 2021 at 11:12 PM Kees Cook <keescook@chromium.org> wrote:
> On Tue, 29 Jun 2021 12:37:00 +0200, Geert Uytterhoeven wrote:
> > On 32-bit:
> >
> >     fs/pstore/blk.c: In function ‘__best_effort_init’:
> >     include/linux/kern_levels.h:5:18: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
> >       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
> >         |                  ^~~~~~
> >     include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
> >        14 | #define KERN_INFO KERN_SOH "6" /* informational */
> >         |                   ^~~~~~~~
> >     include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
> >       373 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >         |         ^~~~~~~~~
> >     fs/pstore/blk.c:314:3: note: in expansion of macro ‘pr_info’
> >       314 |   pr_info("attached %s (%zu) (no dedicated panic_write!)\n",
> >         |   ^~~~~~~
>
> Applied to for-next/pstore, thanks!

Thanks!

> [1/1] pstore/blk: Use "%lu" to format unsigned long
>       https://git.kernel.org/kees/c/c5d4fb2539ca

Looks like this still hasn't made upstream, although it has been in
linux-next since the end of June?  The issue is still present (and
now an error with -Werror), but hidden due to commit d07f3b081ee63226
("mark pstore-blk as broken").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds